Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vllm 0.4.2] prompt log probs changes #1946

Merged
merged 1 commit into from
May 28, 2024

Conversation

sindhuvahinis
Copy link
Contributor

Description

vllm changed the PromptLogProbs dataclass in 0.4.2

in vllm 0.3.3

PromptLogprobs = List[Optional[Dict[int, float]]]

in vllm 0.4.2

@dataclass
class Logprob:
    logprob: float
    rank: Optional[int] = None
    decoded_token: Optional[str] = None

PromptLogprobs = List[Optional[Dict[int, Logprob]]]

Will test it with vllm 0.4.2, once it is ready.

@sindhuvahinis sindhuvahinis requested review from zachgk, frankfliu and a team as code owners May 21, 2024 19:01
@sindhuvahinis
Copy link
Contributor Author

Will merge it, once doing sanity testing in EC2 now.

@sindhuvahinis sindhuvahinis changed the title [Do not merge][vllm 0.4.2] prompt log probs changes [vllm 0.4.2] prompt log probs changes May 28, 2024
@sindhuvahinis sindhuvahinis merged commit 1c95cd5 into deepjavalibrary:master May 28, 2024
8 checks passed
@sindhuvahinis sindhuvahinis deleted the prompt branch June 20, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants