fix sagemaker test suite #1944
Merged
fix sagemaker test suite #1944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddvenk
force-pushed
the
sm-tests
branch
2 times, most recently
from
73c967a to
67c9154
Compare
lanking520
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updating the SM PySDK tests that have been failing for a while. I've removed usage of our custom DJLModel implementation for now, since we need to either update those classes or decide what we do with them moving forward.
For now, these tests validate key functionality on SM endpoints, including:
I also removed the partitioning test cases. Test run with these changes https://github.com/deepjavalibrary/djl-serving/actions/runs/9179268954.
We have discussed removing this suite entirely, but I think this is needed/useful to validate key SM functionality works with our containers