Resolve protected_namespaces warning for pydantic #1834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindhuvahinis
requested review from
zachgk,
frankfliu and
a team
as code owners
zachgk
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In Pydantic v2, the default protected namespace is model_, causing warnings in logs when properties like model_id_or_path are used. However, model_id_or_path doesn't conflict with any Pydantic BaseModel configurations.
This issue also suppresses errors when overriding Pydantic configurations like model_validate. The Machine Learning community has raised concerns, suggesting that Pydantic shouldn't restrict users from using model_, hinting at potential changes in Pydantic v3.
Currently, we're addressing this by setting properties_namespaces to an empty tuple, eliminating warnings since model_id_or_path doesn't override any core Pydantic methods.