[lmi] always configure lmi model instead of just when engine is missing #1727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankfliu
reviewed
Apr 15, 2024
| @@ -92,25 +93,18 @@ private static void setRollingBatch( | |||
| lmiProperties.setProperty("option.rolling_batch", rollingBatch); | |||
| } | |||
|
|
|||
| private static void setEngine( | |||
| private static void setMPIMode( | |||
There was a problem hiding this comment.
Suggested change
| private static void setMPIMode( | |
| private static void setMpiMode( |
| @@ -92,25 +93,18 @@ private static void setRollingBatch( | |||
| lmiProperties.setProperty("option.rolling_batch", rollingBatch); | |||
| } | |||
|
|
|||
| private static void setEngine( | |||
| private static void setMPIMode( | |||
There was a problem hiding this comment.
|
Not really sure what's going on with the windows test, i'll look into it |
frankfliu
force-pushed
the
lmi-configure
branch
from
e349a05 to
2ace916
Compare
frankfliu
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the LMI infer engine into a more general LMI configure method that should run for all LMI models, not just when the engine isn't specified.
The goal of this PR is to serve as the single area where we can: