Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rolling batch type hints part 3 #1584

Merged
merged 2 commits into from
Mar 1, 2024
Merged

rolling batch type hints part 3 #1584

merged 2 commits into from
Mar 1, 2024

Conversation

ydm-amazon
Copy link
Contributor

Description

Adds more type hints.

Also does the following as I increase my understanding of PEP style guidelines:

  • Removes types inside the comments since they are already there in type hints.
  • Adds "None" return type to all functions that return None.

@ydm-amazon ydm-amazon marked this pull request as ready for review February 29, 2024 17:41
@ydm-amazon ydm-amazon requested review from zachgk, frankfliu and a team as code owners February 29, 2024 17:41
@ydm-amazon ydm-amazon merged commit 3fb2464 into deepjavalibrary:master Mar 1, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lanking520 lanking520 lanking520 approved these changes

@zachgk zachgk Awaiting requested review from zachgk zachgk is a code owner

@frankfliu frankfliu Awaiting requested review from frankfliu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ydm-amazon @lanking520