Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vLLM] add enforce eager as an option #1547

Merged
merged 2 commits into from
Feb 19, 2024

Conversation

lanking520
Copy link
Contributor

Description

This option will help to reduce CUDA graph GPU memory addition under some extreme scenarios

@lanking520 lanking520 requested review from zachgk, frankfliu and a team as code owners February 19, 2024 18:19
@maaquib
Copy link
Contributor

maaquib commented Feb 19, 2024

Wondering if we should also add gpu-memory-utilization flag to configure more memory for CUDAGraph [link]

        logger.info("CUDA graphs can take additional 1~3 GiB memory per GPU. "
                    "If you are running out of memory, consider decreasing "
                    "`gpu_memory_utilization` or enforcing eager mode. "
                    "You can also reduce the `max_num_seqs` as needed "
                    "to decrease memory usage.")

@lanking520
Copy link
Contributor Author

@maaquib there are negative impact on this parameter since the general pagedattention will need to use extra GPU spaces to get tokens calculated. I can add this, but not recommend to change on this for particular use cases, it's hard to balance the moving variants of two factors

update test
@lanking520 lanking520 merged commit 4da5f39 into deepjavalibrary:master Feb 19, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants