Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Works with manual initialization #1473

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

zachgk
Copy link
Contributor

@zachgk zachgk commented Jan 10, 2024

This updates DJL Serving to follow the engine initialization standards set in deepjavalibrary/djl#2885. First, it updates the PyEngineProvider to follow the EngineProvider conventions.

It also updates the DependencyManager, fixing some bugs that inspired deepjavalibrary/djl#2934. The dependency manager before this change would always re-register the engine with a new provider. Beforehand, the engine was fully static and unable to re-initialize, so this would not accidentally re-initialize engines. After this, it would re-initialize engines that did not support it causing errors. Instead, it should only register new engines rather than all providers to avoid these accidental re-initialization.

This updates DJL Serving to follow the engine initialization standards set in
deepjavalibrary/djl#2885. First, it updates the
PyEngineProvider to follow the EngineProvider conventions.

It also updates the DependencyManager, fixing some bugs that inspired
deepjavalibrary/djl#2934. The dependency manager before
this change would always re-register the engine with a new provider. Beforehand,
the engine was fully static and unable to re-initialize, so this would not
accidentally re-initialize engines. After this, it would re-initialize engines
that did not support it causing errors. Instead, it should only register new
engines rather than all providers to avoid these accidental re-initialization.
@zachgk zachgk requested review from frankfliu and a team as code owners January 10, 2024 23:07
@zachgk zachgk merged commit e995856 into deepjavalibrary:master Jan 10, 2024
7 checks passed
@zachgk zachgk deleted the engineProviders branch January 10, 2024 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants