Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TRTLLM] Fix bug in handler #1459

Merged
merged 1 commit into from
Jan 5, 2024
Merged

[TRTLLM] Fix bug in handler #1459

merged 1 commit into from
Jan 5, 2024

Conversation

ydm-amazon
Copy link
Contributor

Description

Fixes bug in TensorRT-LLM handler that prevents some error messages from being displayed to user

@ydm-amazon ydm-amazon marked this pull request as ready for review January 5, 2024 20:05
@ydm-amazon ydm-amazon requested review from zachgk, frankfliu and a team as code owners January 5, 2024 20:05
lanking520
lanking520 reviewed Jan 5, 2024
View reviewed changes
Copy link
Contributor

@lanking520 lanking520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self.rolling_batch_type this also can kill too

@ydm-amazon
Copy link
Contributor Author

self.rolling_batch_type this also can kill too

Done

@lanking520 lanking520 merged commit 41fa7a7 into deepjavalibrary:master Jan 5, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lanking520 lanking520 lanking520 approved these changes

@zachgk zachgk Awaiting requested review from zachgk zachgk is a code owner

@frankfliu frankfliu Awaiting requested review from frankfliu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ydm-amazon @lanking520