[Tutorials] add tensorrt llm manual #1412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lanking520
requested review from
zachgk,
frankfliu and
a team
as code owners
frankfliu
reviewed
Dec 19, 2023
| /bin/bash | ||
| ``` | ||
|
|
||
| Then clone the TensorRT-LLM repository inside the container for manual conversion. |
There was a problem hiding this comment.
I think we should provide instruction on how to use our partition script to save the compiled model.
There was a problem hiding this comment.
We will eventually use partiton script to support it. But for now, we have to manually teach customers
rohithkrn
reviewed
Dec 19, 2023
rohithkrn
reviewed
Dec 19, 2023
|
Looks good overall, left minor comments. |
|
@rohithkrn addressed comments |
rohithkrn
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add TRTLLM conversion tutorial manual