[CI][fix] Sagemaker integration test cloudwatch metrics fix #1385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindhuvahinis
requested review from
zachgk,
frankfliu and
a team
as code owners
siddvenk
reviewed
Dec 12, 2023
| outputs = predictor.predict(DEFAULT_PAYLOAD, target_model=model) | ||
| print(outputs) | ||
|
|
||
| if run_benchmark: |
There was a problem hiding this comment.
do we convert run_benchmark to a bool anywhere? this would run if the value is "true" or "false", right (string values)?
There was a problem hiding this comment.
Good one, missed it. Handled it now.
sindhuvahinis
force-pushed
the
ci
branch
2 times, most recently
from
7563cc9 to
a6c08bc
Compare
lanking520
approved these changes
Dec 12, 2023
sindhuvahinis
force-pushed
the
ci
branch
2 times, most recently
from
f09cbe0 to
70efc42
Compare
siddvenk
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sagemaker metrics were not uploaded to cloud watch, because the github action inputs will be empty when the workflow is dispatched through schedule.
Changes in this PR:
run_benchmarkan argument to sagemaker-endpoint-tests script.{name}-{engine_name}-{num_partitions}p-{instance_type}-metric, for exampleopt-1-3-b-deepspeed-2p-ml.g5.8xlarge-throughputTest: