Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[python] Fixes mpi_mode issues #1373

Merged
merged 1 commit into from
Dec 9, 2023
Merged

[python] Fixes mpi_mode issues #1373

merged 1 commit into from
Dec 9, 2023

Conversation

frankfliu
Copy link
Contributor

  1. Properly detect MPI engine for trtllm
  2. Makes mpi_mode consistent with DeepSpeed and MPI engine
  3. Python engine should also respect maxWorkers

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

@frankfliu
[python] Fixes mpi_mode issues
d0a406c 
1. Properly detect MPI engine for trtllm
2. Makes mpi_mode consistent with DeepSpeed and MPI engine
3. Python engine should also respect maxWorkers
@frankfliu frankfliu requested review from zachgk and a team as code owners December 9, 2023 00:15
@frankfliu frankfliu merged commit 101d710 into deepjavalibrary:master Dec 9, 2023
7 checks passed
@frankfliu frankfliu deleted the mpi branch December 9, 2023 01:00
@rohithkrn rohithkrn mentioned this pull request Jan 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lanking520 lanking520 lanking520 approved these changes

@zachgk zachgk Awaiting requested review from zachgk zachgk is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frankfliu @lanking520