Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] Context length estimate datatype #1350

Merged
merged 1 commit into from
Dec 1, 2023
Merged

[fix] Context length estimate datatype #1350

merged 1 commit into from
Dec 1, 2023

Conversation

sindhuvahinis
Copy link
Contributor

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

@sindhuvahinis sindhuvahinis requested review from zachgk, frankfliu and a team as code owners November 30, 2023 01:36
tosterberg
tosterberg requested changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@tosterberg tosterberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build failure is from formatting, run ./gradlew formatPython and commit to fix it. After that LGTM

@sindhuvahinis sindhuvahinis merged commit 1b4f2d1 into deepjavalibrary:master Dec 1, 2023
8 checks passed
@sindhuvahinis sindhuvahinis deleted the tnx branch January 18, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tosterberg tosterberg tosterberg approved these changes

@zachgk zachgk Awaiting requested review from zachgk zachgk is a code owner

@frankfliu frankfliu Awaiting requested review from frankfliu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sindhuvahinis @tosterberg