[doc] Placeholder for TrtLLM tutorial and tuning guide #1333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindhuvahinis
requested review from
zachgk,
frankfliu and
a team
as code owners
tosterberg
approved these changes
Nov 21, 2023
rohithkrn
reviewed
Nov 21, 2023
zachgk
approved these changes
Nov 21, 2023
There was a problem hiding this comment.
I feel like these doc placeholders look fine, but they will need to be included in the mkdocs nav. We should also look through some of our existing docs with the mindset of when would customers wish they had the link to the tuning guide/tutorial. Maybe a link from the LMI configuration doc?
rohithkrn
reviewed
Nov 21, 2023
serving/docs/lmi/configurations_large_model_inference_containers.md
Outdated
Show resolved
Hide resolved
rohithkrn
reviewed
Nov 21, 2023
| @@ -3,7 +3,7 @@ | |||
| There are a number of shared configurations for python models running large language models. | |||
| They are also available through the [Large Model Inference Containers](https://github.com/aws/deep-learning-containers/blob/master/available_images.md#large-model-inference-containers). | |||
|
|
|||
| ### Common ([doc](https://github.com/deepjavalibrary/djl-serving/blob/521e0edadec35b04ec9e1d51b9e406119efd0235/serving/docs/configurations_large_model_inference_containers.md#common-doc)) | |||
| ### Common ([doc](https://docs.aws.amazon.com/sagemaker/latest/dg/large-model-inference-configuration.html)) | |||
There was a problem hiding this comment.
also curious, why we are linking awsdocs here since the current github page also contains the same table or possibly more recent parameters as awsdocs updates can take time
There was a problem hiding this comment.
Yes, AWS docs should refer to this github. This github contains most up-to-date info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR to add placeholder for TrtLLM tutorial and tuning guide