Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vllm] standardize input parameters #1301

Merged
merged 1 commit into from
Nov 9, 2023
Merged

[vllm] standardize input parameters #1301

merged 1 commit into from
Nov 9, 2023

Conversation

frankfliu
Copy link
Contributor

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

@frankfliu frankfliu requested review from zachgk and a team as code owners November 9, 2023 17:24
@lanking520 lanking520 merged commit 9015c08 into deepjavalibrary:master Nov 9, 2023
8 checks passed
maaquib pushed a commit to maaquib/djl-serving that referenced this pull request Nov 10, 2023
@frankfliu
[vllm] standardize input parameters (deepjavalibrary#1301)
29a8407
@frankfliu frankfliu deleted the vllm branch December 1, 2023 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sindhuvahinis sindhuvahinis sindhuvahinis approved these changes

@zachgk zachgk Awaiting requested review from zachgk zachgk is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frankfliu @sindhuvahinis @lanking520