Huggingface configurations refactoring #1283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindhuvahinis
force-pushed
the
hf
branch
3 times, most recently
from
b59f114 to
953aee7
Compare
sindhuvahinis
requested review from
zachgk,
frankfliu and
a team
as code owners
sindhuvahinis
commented
Nov 7, 2023
| # device map is not required for lmi dist and | ||
| if properties['rolling_batch'] == RollingBatchEnum.lmidist or \ | ||
| properties['rolling_batch'] == RollingBatchEnum.vllm: | ||
| return properties |
There was a problem hiding this comment.
@xyang16 @KexinFeng @lanking520
I am not validating whether device_map exists for lmi dist and vllm. And also not inserting load_in_8bit in kwargs. Kindly check if this is okay,
There was a problem hiding this comment.
device map is not important. this is only applies to scheduler and HF Accelerate path
sindhuvahinis
commented
Nov 7, 2023
engines/python/setup/djl_python/rolling_batch/lmi_dist_rolling_batch.py
Outdated
Show resolved
Hide resolved
sindhuvahinis
commented
Nov 7, 2023
| bitsandbytes8 = 'bitsandbytes8' | ||
|
|
||
| # supported by vllm | ||
| awq = 'awq' |
There was a problem hiding this comment.
Kindly verify whether does it cover all supported quantization methods. lmi-dist has tests for gptq. vllm does not have test case for awq in our pipeline. Let me add it.
There was a problem hiding this comment.
there is no awq test for vLLM, feel free to add it
lanking520
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests:
Added unit test cases.
Tested CI test cases manually in ec2. And also ran in github actions
HF https://github.com/deepjavalibrary/djl-serving/actions/runs/6790943108/job/18461535915
HF lora https://github.com/deepjavalibrary/djl-serving/actions/runs/6791093901/job/18462088800
Rolling batch changes https://github.com/deepjavalibrary/djl-serving/actions/runs/6790720395/job/18460807680