[TRTLLM] some clean up on trtllm handler #1248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lanking520
force-pushed
the
trtllm
branch
2 times, most recently
from
10e18f5 to
95c23e2
Compare
rohithkrn
reviewed
Nov 2, 2023
| _rolling_batch_cls = get_rolling_batch_class_from_str( | ||
| self.rolling_batch_type, is_mpi, self.model_config) | ||
| self.rolling_batch = _rolling_batch_cls(model_id_or_path, self.device, | ||
| if "trt_llm_model_name" in properties: |
There was a problem hiding this comment.
instead of converting properties to kwargs in the handler, it's better if we pass the properties to the toolkit and handler everything there. This conversion misses trt_* properties that users can set
rohithkrn
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Clean up on the handler