Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] update context estimate interface #1194

Merged
merged 1 commit into from
Oct 18, 2023
Merged

[fix] update context estimate interface #1194

merged 1 commit into from
Oct 18, 2023

Conversation

tosterberg
Copy link
Contributor

Description

Brief description of what this PR is about

Updating the way that the context estimate is passed to the *ForSampling classes, so that it is only used for Llama models.

  • If this change is a backward incompatible change, why must this change be made?
    No
  • Interesting edge cases to note here
    No

@tosterberg tosterberg marked this pull request as ready for review October 18, 2023 02:45
@tosterberg tosterberg requested review from zachgk, frankfliu and a team as code owners October 18, 2023 02:45
@tosterberg tosterberg merged commit ff0f654 into deepjavalibrary:master Oct 18, 2023
5 of 8 checks passed
@tosterberg tosterberg deleted the context-estimate branch December 4, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lanking520 lanking520 lanking520 approved these changes

@zachgk zachgk Awaiting requested review from zachgk zachgk is a code owner

@frankfliu frankfliu Awaiting requested review from frankfliu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tosterberg @lanking520