Creates auto increment ID for models #1109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankfliu
reviewed
Sep 25, 2023
| @@ -97,13 +97,18 @@ public final class ModelInfo<I, O> extends WorkerPoolConfig<I, O> { | |||
| private transient Map<String, Adapter> adapters; | |||
| private transient Engine engine; | |||
|
|
|||
| private ModelInfo() { | |||
| super(); | |||
There was a problem hiding this comment.
super() is not necessary, default constructor will be invoked automatically.
This creates a new auto-increment ID to differentiate models with the same name and adds the ID to the toString and logging.
This removes the change to the external API for better compatibility. It also avoids having the ID passed in exceptions, just in logs.
siddvenk
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an auto increment ID to models, their toString, and logging. It allows them to be differentiated if two models share the same name. It is unified with the existing auto increment system in worker threads (which also had it's logging improved).
The IDs have both a prefix and leading zeros for consistent search:
WT-0001 for worker threads
M-0001 for models