Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[serving] Allows print access log to console #1009

Merged
merged 1 commit into from
Aug 10, 2023
Merged

[serving] Allows print access log to console #1009

merged 1 commit into from
Aug 10, 2023

Conversation

frankfliu
Copy link
Contributor

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

@frankfliu frankfliu requested review from zachgk and a team as code owners August 9, 2023 23:31
zachgk
zachgk approved these changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@zachgk zachgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, we should probably add a doc somewhere explaining the log4j configurations we have and how to use them

@frankfliu frankfliu merged commit bc7fdfd into deepjavalibrary:master Aug 10, 2023
@frankfliu frankfliu deleted the log branch August 10, 2023 00:02
frankfliu added a commit that referenced this pull request Aug 10, 2023
@frankfliu
[serving] Allows print access log to console (#1009)
fd813aa
KexinFeng pushed a commit to KexinFeng/djl-serving-forked that referenced this pull request Aug 16, 2023
@frankfliu
[serving] Allows print access log to console (deepjavalibrary#1009)
f9bd8fb
KexinFeng pushed a commit to KexinFeng/djl-serving-forked that referenced this pull request Aug 16, 2023
@frankfliu @KexinFeng
[serving] Allows print access log to console (deepjavalibrary#1009)
7ef5d23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lanking520 lanking520 lanking520 approved these changes

@zachgk zachgk zachgk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frankfliu @zachgk @lanking520