[python] validate each request in the batch #1008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lanking520
reviewed
Aug 9, 2023
| if self.rolling_batch_type: | ||
| if inputs.get_property("reset_rollingbatch"): | ||
| self.rolling_batch.reset() | ||
| result = self.rolling_batch.inference(input_data, parameters) | ||
| for i in range(inputs.get_batch_size()): | ||
| outputs.add(result[i], key="data", batch_index=i) | ||
| for i in range(len(input_data)): |
| if err: | ||
| outputs.add(err, key="data", batch_index=i) | ||
| else: | ||
| outputs.add(result[i], key="data", batch_index=i) |
There was a problem hiding this comment.
i is not the right index, probably we need to +1 everytime we insert a new value. Or use iterator to iter a value.
lanking520
approved these changes
Aug 10, 2023
lanking520
reviewed
Aug 10, 2023
|
|
||
| prediction = self.hf_pipeline(input_data, **parameters[0]) | ||
| else: | ||
| prediction = [] |
There was a problem hiding this comment.
need to check rolling batch here. If rolling batch, need to return all errors
frankfliu
force-pushed
the
batch
branch
2 times, most recently
from
bf92704 to
252b199
Compare
lanking520
reviewed
Aug 10, 2023
| inputs) | ||
| if len(input_data) == 0: | ||
| for i in range(len(batch)): | ||
| outputs.add(errors.get(i), key="data", batch_index=i) |
There was a problem hiding this comment.
Will this work for dynamic batch?
There was a problem hiding this comment.
this place may also need the json double dumps
frankfliu
force-pushed
the
batch
branch
2 times, most recently
from
9aa4816 to
741beb8
Compare
lanking520
approved these changes
Aug 10, 2023
lanking520
approved these changes
Aug 10, 2023
frankfliu
added a commit
that referenced
this pull request
Aug 10, 2023
KexinFeng
pushed a commit
to KexinFeng/djl-serving-forked
that referenced
this pull request
Aug 16, 2023
KexinFeng
pushed a commit
to KexinFeng/djl-serving-forked
that referenced
this pull request
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Brief description of what this PR is about