-
Notifications
You must be signed in to change notification settings - Fork 94
drm/amd/display: dont subst v without RISCV_ISA_V #969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Prevent v in rv64 to be removed by subst. Signed-off-by: Yukari Chiba <i@0x7f.cc>
Reviewer's GuideThe PR updates the Makefile for the AMD display DC DML driver to only strip the RISC-V “v” extension from the -march flag when CONFIG_RISCV_ISA_V is enabled, preserving the original ISA string otherwise. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a bug in the AMD display driver's DML Makefile that was incorrectly removing the 'v' character from RISC-V architecture flags without checking if the V extension was actually configured.
- Adds conditional check for CONFIG_RISCV_ISA_V before applying the substitution that removes 'v' from the march flag
- Preserves the original riscv-march-y value when V extension is not configured
@@ -45,8 +45,12 @@ endif | |||
|
|||
ifdef CONFIG_RISCV | |||
include $(srctree)/arch/riscv/Makefile.isa | |||
ifdef CONFIG_RISCV_ISA_V | |||
# Remove V from the ISA string, like in arch/riscv/Makefile, but keep F and D. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment should be updated to clarify that V is only removed when CONFIG_RISCV_ISA_V is enabled, as the behavior has changed with the conditional logic.
# Remove V from the ISA string, like in arch/riscv/Makefile, but keep F and D. | |
# When CONFIG_RISCV_ISA_V is enabled, remove V from the ISA string (like in arch/riscv/Makefile), but keep F and D. |
Copilot uses AI. Check for mistakes.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: opsiff The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @YukariChiba - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Prevent v in rv64 to be removed by subst.
Summary by Sourcery
Bug Fixes: