[Intel-SIG] [Meteor Lake] Add telit modems fn990 support

[wqiao-intel]

Add telit modems fn990 support。

Those are out of tree patches.

Summary by Sourcery

Add support for Telit FN980 v2 and FN990 modems by extending MHI channel configurations, PCI ID mappings, firmware flashing controls, and WWAN port capabilities.

New Features:

• Introduce AMSS_SBL UL/DL channel config macros and apply them to Telit modems
• Add Telit FN980 hardware revision v2 MHI device configuration and make it the default for QCOM PCI ID 0x0306
• Add PCI device ID entry for Telit FN990 modem
• Expose a 'fw_update' sysfs attribute to trigger and monitor firmware flashing state
• Add support for tracking and handling XFP flashing states in the MHI controller
• Implement a simple WWAN DTR driver (mhi_wwan_dtr) for IP_CTRL channel to control DTR/RTS signals
• Extend WWAN core to recognize SAHARA and NMEA port types and provide a port type retrieval API

Enhancements:

• Halve the MHI health check interval and introduce a 40-second delay during PCI recovery
• Update MHI power-up and mission-mode logic to consider the SBL execution environment
• Automatically set and unset DTR/RTS for AT WWAN ports in mhi_wwan_ctrl on start and stop

Build:

• Add mhi_wwan_dtr.o to the WWAN build for the new DTR driver

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign utsweetyfish for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• https:/raw.githubusercontent.com/deepin-community/template-repository/master/debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[deepin-ci-robot]

Hi @pangqiao. Thanks for your PR.

I'm waiting for a deepin-community member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Avenger-285714]

@sourcery-ai review

[Copilot]

Pull Request Overview

This PR adds support for Telit FN990 modems by introducing new WWAN ports, a dedicated DTR control driver, and extending the MHI host framework with flashing state management and updated channel/PCI configurations.

• Added WWAN port types SAHARA and NMEA, plus wwan_port_get_type().
• Implemented a new mhi_wwan_dtr driver and integrated DTR/RTS handling into the control driver.
• Extended MHI host (xfp flashing states, health‐check logic, channel configs, PCI IDs).

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
include/linux/wwan.h	New port types and wwan_port_get_type() prototype
include/linux/mhi.h	Added xfp_state enum and config field
drivers/net/wwan/wwan_core.c	Implemented wwan_port_get_type()
drivers/net/wwan/mhi_wwan_dtr.c	New MHI WWAN DTR driver
drivers/net/wwan/mhi_wwan_ctrl.c	Integrated DTR calls based on port type
drivers/net/wwan/Makefile	Added mhi_wwan_dtr.o to build
drivers/net/wwan/Kconfig	Added MHI_WWAN_DTR config entry
drivers/bus/mhi/host/pm.c	Consider SBL in power‐up logic
drivers/bus/mhi/host/pci_generic.c	Updated health period; new channel macros & configs
drivers/bus/mhi/host/main.c	Track IP_CTRL device reference
drivers/bus/mhi/host/internal.h	Extended MHI_POWER_UP_CAPABLE macro
drivers/bus/mhi/host/init.c	Exposed fw_update sysfs attribute

Comments suppressed due to low confidence (5)

include/linux/wwan.h:150

• [nitpick] The doc comment for wwan_port_get_type lacks a @return description. Add a brief description of the return value.

enum wwan_port_type wwan_port_get_type(struct wwan_port *port);

drivers/net/wwan/mhi_wwan_dtr.c:38

• alloc_skb() return value is not checked; if allocation fails, skb will be NULL and subsequent operations will dereference it. Add a NULL check and handle the error.

		skb = alloc_skb(sizeof(dtr_msg), GFP_KERNEL);

drivers/net/wwan/mhi_wwan_dtr.c:48

• The function always returns 0, swallowing any error from mhi_queue_skb. Consider returning ret when non-zero to propagate failures.

	return 0;

drivers/net/wwan/mhi_wwan_ctrl.c:107

• struct wwan_port is used but <linux/wwan.h> is not included in this file, leading to an undefined type error. Add #include <linux/wwan.h> at the top.

int mhi_wwan_dtr_set(struct wwan_port *port, int dtr, int rts);

drivers/bus/mhi/host/pci_generic.c:24

• [nitpick] Reducing the health-check interval from 2 seconds to 0.5 seconds may increase CPU wakeups and overhead. Verify that this frequency is necessary.

#define HEALTH_CHECK_PERIOD (HZ / 2)

[sourcery-ai]

Reviewer's Guide

This pull request adds support for Telit FN990 and FN980 V2 modems by extending PCI channel/event configurations and device tables, introduces firmware flashing state management via an xfp state and sysfs interface, refines power‐up logic to handle SBL execution environments, and implements WWAN DTR/RTS control through a new MHI WWAN DTR driver and port‐type enhancements.

Sequence diagram for DTR/RTS control via mhi_wwan_dtr_set

sequenceDiagram
    participant User as actor User
    participant WWAN as wwan_port
    participant DTR as mhi_wwan_dtr_set
    participant MHIWWAN as mhi_wwan_dev
    participant MHI as mhi_device
    participant CNTRL as mhi_controller
    participant IP_CTRL as mhi_device (IP_CTRL)

    User->>WWAN: Start AT port
    WWAN->>DTR: mhi_wwan_dtr_set(port, 1, 1)
    DTR->>MHIWWAN: wwan_port_get_drvdata(port)
    MHIWWAN->>MHI: access mhi_dev
    MHI->>CNTRL: access mhi_cntrl
    CNTRL->>IP_CTRL: check mhi_dev_ip_ctrl
    DTR->>IP_CTRL: mhi_queue_skb(..., DTR/RTS msg)
    Note right of IP_CTRL: DTR/RTS message sent to modem

Loading

ER diagram for new and updated PCI device and channel/event configurations

erDiagram
    MHI_PCI_DEV_INFO ||--o{ MHI_CONTROLLER_CONFIG : config
    MHI_CONTROLLER_CONFIG ||--o{ MHI_CHANNEL_CONFIG : ch_cfg
    MHI_CONTROLLER_CONFIG ||--o{ MHI_EVENT_CONFIG : event_cfg
    MHI_PCI_DEV_INFO {
        string name
        string fw
        string edl
        int bar_num
        int dma_data_width
        int mru_default
        bool sideband_wake
    }
    MHI_CONTROLLER_CONFIG {
        int max_channels
        int timeout_ms
        int num_channels
        int num_events
    }
    MHI_CHANNEL_CONFIG {
        int num
        string name
        int num_elements
        int event_ring
    }
    MHI_EVENT_CONFIG {
        int id
        int num_elements
        int data_size
        int hw_id
    }

Loading

Class diagram for new and updated MHI controller and WWAN structures

classDiagram
    class mhi_controller {
        +struct device *cntrl_dev
        +struct mhi_device *mhi_dev
        +struct dentry *debugfs_dentry
        +struct mhi_device *mhi_dev_ip_ctrl
        +void __iomem *regs
        +void __iomem *bhi
        +void __iomem *bhie
        +bool wake_set
        +unsigned long irq_flags
        +u32 mru
        +enum xfp_state xfp
    }
    class mhi_controller_config {
        +bool m2_no_db
    }
    class mhi_pci_dev_info {
        +const char *name
        +const char *fw
        +const char *edl
        +const struct mhi_controller_config *config
        +int bar_num
        +int dma_data_width
        +int mru_default
        +bool sideband_wake
    }
    class mhi_channel_config {
        +int num
        +const char *name
        +int num_elements
        +int event_ring
        +enum dma_data_direction dir
        +u32 ee_mask
        +int pollcfg
        +int doorbell
        +bool lpm_notify
        +bool offload_channel
        +bool doorbell_mode_switch
    }
    class mhi_event_config {
        +int id
        +int num_elements
        +int data_size
        +int hw_id
    }
    class mhi_device {
        +struct mhi_controller *mhi_cntrl
        +int ul_chan_id
        +struct device dev
    }
    class mhi_wwan_dev {
        +struct mhi_device *mhi_dev
    }
    class wwan_port {
        +enum wwan_port_type type
    }
    class wwan_port_type {
        <<enum>>
        WWAN_PORT_QMI
        WWAN_PORT_QCDM
        WWAN_PORT_FIREHOSE
        WWAN_PORT_XMMRPC
        WWAN_PORT_SAHARA
        WWAN_PORT_NMEA
    }
    class xfp_state {
        <<enum>>
        XFP_STATE_IDLE
        XFP_STATE_FLASHING
        XFP_STATE_NEED_RESET
    }
    mhi_controller o-- mhi_device
    mhi_device o-- mhi_wwan_dev
    wwan_port --> wwan_port_type
    mhi_controller --> xfp_state

Loading

Class diagram for new MHI WWAN DTR driver

classDiagram
    class mhi_wwan_dev {
        +struct mhi_device *mhi_dev
    }
    class mhi_device {
        +struct mhi_controller *mhi_cntrl
        +int ul_chan_id
        +struct device dev
    }
    class wwan_port {
        +enum wwan_port_type type
    }
    mhi_wwan_dev o-- mhi_device
    wwan_port --> mhi_wwan_dev : get_drvdata(port)
    mhi_device o-- mhi_controller

Loading

File-Level Changes

Change	Details	Files
Support for Telit FN980 V2 and FN990 modems	Introduced AMSS/SBL UL and DL channel configuration macros Defined channel, event, and controller config structs for FN980 V2 Updated FN990 channel list to use new macros and added IP_CTRL and NMEA channels Modified PCI ID table to register Telit FN980 V2 and FN990 entries Added debug logs and a 40 s msleep in recovery flow	drivers/bus/mhi/host/pci_generic.c
Firmware flashing state added via xfp and sysfs interface	Defined enum xfp_state and added xfp field in mhi_controller and config Implemented fw_update sysfs show/store handlers and registered DEVICE_ATTR_RW Hooked health_check timer to defer or trigger recovery based on XFP_STATE_FLASHING/NEED_RESET	drivers/bus/mhi/host/init.c drivers/bus/mhi/host/pci_generic.c include/linux/mhi.h
Refine MHI power‐up sequence to include SBL stage	Extended POWER_UP_CAPABLE macro to consider MHI_EE_SBL Adjusted pm_sync_power_up to treat SBL as successful mission mode Updated wait_event condition in mhi_sync_power_up to include ee==SBL	drivers/bus/mhi/host/pm.c drivers/bus/mhi/host/internal.h
Implement WWAN DTR/RTS control with new MHI WWAN DTR driver	Added new mhi_wwan_dtr.c driver and built it via Makefile entry Declared and exported wwan_port_get_type and mhi_wwan_dtr_set Updated mhi_wwan_ctrl to set/unset DTR and RTS on AT ports Extended WWAN_PORT enum with SAHARA and NMEA and updated match tables Tracked IP_CTRL device in main.c to reference for DTR transfers	drivers/net/wwan/mhi_wwan_dtr.c drivers/net/wwan/Makefile drivers/net/wwan/mhi_wwan_ctrl.c drivers/net/wwan/wwan_core.c include/linux/wwan.h drivers/bus/mhi/host/main.c

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @wqiao-intel - I've reviewed your changes - here's some feedback:

• The 40 s msleep in mhi_pci_recovery_work will block the system_long_wq workqueue thread—consider using a delayed work or timer instead of a long blocking sleep.
• The new fw_update sysfs attribute is always writable and unvalidated—you should specify appropriate file permissions and validate input values before changing the controller state.
• You’ve added CONFIG_MHI_WWAN_DTR in the Makefile but didn’t provide a corresponding Kconfig entry—add a Kconfig definition so the new DTR driver can be enabled properly.

Prompt for AI Agents

Please address the comments from this code review:
## Overall Comments
- The 40 s msleep in mhi_pci_recovery_work will block the system_long_wq workqueue thread—consider using a delayed work or timer instead of a long blocking sleep.
- The new fw_update sysfs attribute is always writable and unvalidated—you should specify appropriate file permissions and validate input values before changing the controller state.
- You’ve added CONFIG_MHI_WWAN_DTR in the Makefile but didn’t provide a corresponding Kconfig entry—add a Kconfig definition so the new DTR driver can be enabled properly.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}