Skip to content

net: stmmac: dwmac-phytium: compat some FT2000 #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
opsiff merged 1 commit into from
Jul 12, 2024
Merged

net: stmmac: dwmac-phytium: compat some FT2000 #316

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 24 additions & 1 deletion drivers/net/ethernet/stmicro/stmmac/dwmac-phytium.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,21 @@ static int phytium_dwmac_probe(struct platform_device *pdev)
return -ENOMEM;

plat->phy_interface = device_get_phy_mode(&pdev->dev);
#ifdef CONFIG_ACPI
static const struct acpi_device_id phytium_old_acpi_id[] = {
{ .id = "FTGM0001" }, // compat FT2000/4 id
{ }
};
/* "phy-mode" in phytium platform DSDT is not correct in some old device.
* Force this PHY mode to rgmii-rxid and info of its use.
* If the phy-mode rgmii is realy used, a blacklist may need to be added.
*/
if (acpi_match_device_ids(to_acpi_device(&pdev->dev), phytium_old_acpi_id) &&
Copy link

@github-actions github-actions bot Jul 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?)

plat->phy_interface == PHY_INTERFACE_MODE_RGMII) {
plat->phy_interface = PHY_INTERFACE_MODE_RGMII_RXID;
dev_info(&pdev->dev, "phytium workaround: phy-mode from rgmii to rgmii-rxid\n");
}
#endif
if (plat->phy_interface < 0)
return plat->phy_interface;

Expand Down Expand Up @@ -153,7 +168,15 @@ static int phytium_dwmac_probe(struct platform_device *pdev)
plat->dma_cfg->aal = fwnode_property_read_bool(fwnode, "snps,aal");
plat->dma_cfg->fixed_burst = fwnode_property_read_bool(fwnode, "snps,fixed-burst");
plat->dma_cfg->mixed_burst = fwnode_property_read_bool(fwnode, "snps,mixed-burst");

#ifdef CONFIG_ACPI
/* Some old phytium 2000/4 FTGM0001 cannot auto deferred stmmac DMA settings
* show kernel error 'DMA descriptors allocation failed'
*/
if (acpi_match_device_ids(to_acpi_device(&pdev->dev), phytium_old_acpi_id)) {
pdev->dev.dma_ops = NULL; // solved set DMA mask Failed
plat->host_dma_width = 32;
}
#endif
plat->axi->axi_lpi_en = false;
plat->axi->axi_xit_frm = false;
plat->axi->axi_wr_osr_lmt = 7;
Expand Down