Skip to content

Conversation

@studyhu
Copy link

@studyhu studyhu commented May 24, 2024

This driver supports Phytium PCI PS/2 controller.

This driver supports Phytium PCI PS/2 controller.

Signed-off-by: Cheng Quan <chengquan@phytium.com.cn>
Signed-off-by: Chen Baozi <chenbaozi@phytium.com.cn>
Signed-off-by: Chen Zhenhua <chenzhenhua@phytium.com.cn>
Signed-off-by: Wang Yinfeng <wangyinfeng@phytium.com.cn>
Signed-off-by: Hu Yeqing <huyeqing2074@phytium.com.cn>
@deepin-ci-robot
Copy link

Hi @studyhu. Thanks for your PR.

I'm waiting for a deepin-community member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign goldendeng for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@opsiff
Copy link
Member

opsiff commented May 24, 2024

/ok-to-test

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • phytium_ps2_irq函数中,scancode的赋值应该在if语句的内部,否则在rxcount为0时scancode会被赋值为0,这可能导致后续的flag赋值不正确。
  • phytium_ps2_irq函数中的rxcount检查应该在循环外部,以确保在rxcount为0时能够正确地处理timeout interrupt。
  • phytium_ps2_write函数中的cpu_relax()调用可能是多余的,因为writel函数在Linux中会自动同步。
  • phytium_pci_ps2_probe函数中的ret变量在free分支中被赋值,但在out分支中没有被赋值,这可能导致未初始化的变量被使用。
  • phytium_pci_ps2_probe函数中的serio_register_port调用应该在kzalloc成功后立即进行,以确保在内存分配失败时能够正确释放资源。
  • phytium_pci_ps2_remove函数中的pcim_iounmap_regions调用应该在serio_unregister_port之后进行,以确保资源正确释放。

是否建议立即修改:

@Avenger-285714 Avenger-285714 merged commit 8fa583c into deepin-community:linux-6.6.y May 24, 2024
opsiff pushed a commit to opsiff/UOS-kernel that referenced this pull request Dec 2, 2025
[ Upstream commit d52dea4 ]

If user provides a large value (such as 0x80) for parameter
prefetch_mem_region_instance in vm_bind ioctl, it will cause
BIT(prefetch_region) overflow as below:
"
 ------------[ cut here ]------------
 UBSAN: shift-out-of-bounds in drivers/gpu/drm/xe/xe_vm.c:3414:7
 shift exponent 128 is too large for 64-bit type 'long unsigned int'
 CPU: 8 UID: 0 PID: 53120 Comm: xe_exec_system_ Tainted: G        W           6.18.0-rc1-lgci-xe-kernel+ deepin-community#200 PREEMPT(voluntary)
 Tainted: [W]=WARN
 Hardware name: ASUS System Product Name/PRIME Z790-P WIFI, BIOS 0812 02/24/2023
 Call Trace:
  <TASK>
  dump_stack_lvl+0xa0/0xc0
  dump_stack+0x10/0x20
  ubsan_epilogue+0x9/0x40
  __ubsan_handle_shift_out_of_bounds+0x10e/0x170
  ? mutex_unlock+0x12/0x20
  xe_vm_bind_ioctl.cold+0x20/0x3c [xe]
 ...
"
Fix it by validating prefetch_region before the BIT() usage.

v2: Add Closes and Cc stable kernels. (Matt)

Reported-by: Koen Koning <koen.koning@intel.com>
Reported-by: Peter Senna Tschudin <peter.senna@linux.intel.com>
Fixes: dd08ebf ("drm/xe: Introduce a new DRM driver for Intel GPUs")
Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/6478
Cc: <stable@vger.kernel.org> # v6.8+
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
Signed-off-by: Shuicheng Lin <shuicheng.lin@intel.com>
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Link: https://patch.msgid.link/20251112181005.2120521-2-shuicheng.lin@intel.com
(cherry picked from commit 8f565bdd14eec5611cc041dba4650e42ccdf71d9)
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
(cherry picked from commit d52dea4)
Signed-off-by: Shuicheng Lin <shuicheng.lin@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
(cherry picked from commit 23ba534d73c6f7fa76eaeaa2b96e1719cd310bc4)
Signed-off-by: Wentao Guan <guanwentao@uniontech.com>
lanlanxiyiji pushed a commit that referenced this pull request Dec 22, 2025
This driver supports Phytium PCI PS/2 controller.

Signed-off-by: Cheng Quan <chengquan@phytium.com.cn>
Signed-off-by: Chen Baozi <chenbaozi@phytium.com.cn>
Signed-off-by: Chen Zhenhua <chenzhenhua@phytium.com.cn>
Signed-off-by: Wang Yinfeng <wangyinfeng@phytium.com.cn>
Signed-off-by: Hu Yeqing <huyeqing2074@phytium.com.cn>
Link: #200
[ drop pcim_iounmap_regions for v6.18, see ebf7547 ("mtip32xx: Remove unnecessary pcim_iounmap_regions() calls") ]
(cherry picked from commit 3ba5c5c)
Signed-off-by: Wentao Guan <guanwentao@uniontech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants