Skip to content

Conversation

@MingcongBai
Copy link
Contributor

@MingcongBai MingcongBai commented May 22, 2024

Picked and rebased from #118.

From original pull request:

add net interface driver to support phytium DWMAC controler on d2000 .

Builds tested

  • amd64
  • arm64
  • loong64

@deepin-ci-robot deepin-ci-robot requested review from BLumia and myml May 22, 2024 02:58
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign xzl01 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link

Hi @MingcongBai. Thanks for your PR.

I'm waiting for a deepin-community member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Li Wencheng added 2 commits May 29, 2024 08:38
Add a memory barrier to sync TX descriptor to avoid data error.

Besides, increase the ring buffer size to avoid buffer overflow.

Signed-off-by: Wang Zhimin <wangzhimin1179@phytium.com.cn>
Signed-off-by: Li Wencheng <liwencheng@phytium.com.cn>
Signed-off-by: Chen Baozi <chenbaozi@phytium.com.cn>
Signed-off-by: Wang Yinfeng <wangyinfeng@phytium.com.cn>
Change-Id: I47bd63a472c915b7f88b16921e8fa63bf8b284d9
Modify stmmmac driver to support phytium DWMAC controler.

Signed-off-by: Wang Zhimin <wangzhimin1179@phytium.com.cn>
Signed-off-by: Li Wencheng <liwencheng@phytium.com.cn>
Signed-off-by: Chen Baozi <chenbaozi@phytium.com.cn>
Signed-off-by: Wang Yinfeng <wangyinfeng@phytium.com.cn>
Change-Id: I878377c5fb88935dcbc7b83f368ae5408938f890
@MingcongBai MingcongBai force-pushed the bai/kernel-rolling/phytium-dwmac branch from e9e6161 to 1b944bf Compare May 29, 2024 00:38
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • phytium_dwmac_probe函数中,clk_name变量被重复使用,应该使用不同的变量名以避免潜在的命名冲突。
  • snprintf函数用于生成clk_name时,应该检查是否溢出,以避免缓冲区溢出错误。
  • fwnode_property_read_u64函数可能返回负数,应该检查返回值并适当处理。
  • stmmac_res.wol_irq被初始化为stmmac_res.irq,这可能不是预期的行为,应该确认是否需要初始化wol_irq
  • stmmac_res.lpi_irq被初始化为-1,这可能不是预期的行为,应该确认是否需要初始化lpi_irq
  • stmmac_pltfr_remove函数调用可能依赖于plat结构,但当前的调用顺序没有反映这种依赖关系。
  • clk_unregister_fixed_rate函数调用可能依赖于plat结构,但当前的调用顺序没有反映这种依赖关系。
  • wmb();调用可能依赖于p结构,但当前的调用顺序没有反映这种依赖关系。
  • ndesc_prepare_tx_desc函数中,p结构的使用没有反映其具体含义,应该添加注释以解释其用途。
  • of_match_ptr函数调用可能依赖于phytium_dwmac_of_match数组,但当前的调用顺序没有反映这种依赖关系。
  • ACPI_PTR宏可能需要一个参数来指定数组的大小,以确保正确处理数组。

是否建议立即修改:

@MingcongBai
Copy link
Contributor Author

MingcongBai commented May 29, 2024

Builds tested:

  • amd64
  • arm64
  • loong64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants