Skip to content

Conversation

@opsiff
Copy link
Member

@opsiff opsiff commented Dec 26, 2025

deepin inclusion
category: feature

Tested on DMI: MECHREVO YAOSHI Series/YAOSHI Series-X6AR55xY, BIOS N.1.18MRO24 08/06/2025
case: Intel Ultra 2 i2c touchpad support

Log:
[ 4.671551] ntfs3: Warning: Activated 64 bits per cluster. Windows does not support this
[ 4.671552] ntfs3: Read-only LZX/Xpress compression included
[ 4.676241] nvidia 0000:02:00.0: vgaarb: VGA decodes changed: olddecodes=io+mem,decodes=none:owns=none
[ 4.686034] intel-hid INTC10CB:00: failed to enable HID power button
[ 4.689088] NVRM: loading NVIDIA UNIX Open Kernel Module for x86_64 580.119.02 Release Build (dvs-builder@U22-I3-B15-03-5) Mon Dec 8 07:51:55 UTC 2025
[ 4.698028] input: HDA NVidia HDMI/DP,pcm=3 as /devices/pci0000:00/0000:00:06.3/0000:02:00.1/sound/card0/input17
[ 4.728742] nvidia-modeset: Loading NVIDIA UNIX Open Kernel Mode Setting Driver for x86_64 580.119.02 Release Build (dvs-builder@U22-I3-B15-03-5) Mon Dec 8 07:38:31 UTC 2025
[ 4.729475] snd_hda_codec_realtek hdaudioC1D0: autoconfig for ALC274: line_outs=1 (0x17/0x0/0x0/0x0/0x0) type:speaker
[ 4.729478] snd_hda_codec_realtek hdaudioC1D0: speaker_outs=0 (0x0/0x0/0x0/0x0/0x0)
[ 4.729479] snd_hda_codec_realtek hdaudioC1D0: hp_outs=1 (0x21/0x0/0x0/0x0/0x0)
[ 4.729480] snd_hda_codec_realtek hdaudioC1D0: mono: mono_out=0x0
[ 4.729481] snd_hda_codec_realtek hdaudioC1D0: inputs:
[ 4.729482] snd_hda_codec_realtek hdaudioC1D0: Internal Mic=0x12
[ 4.729483] snd_hda_codec_realtek hdaudioC1D0: Headset Mic=0x19
[ 4.730400] RPC: Registered named UNIX socket transport module.
[ 4.730403] RPC: Registered udp transport module.
[ 4.730404] RPC: Registered tcp transport module.
[ 4.730404] RPC: Registered tcp-with-tls transport module.
[ 4.730405] RPC: Registered tcp NFSv4.1 backchannel transport module.
[ 4.734010] [drm] [nvidia-drm] [GPU ID 0x00000200] Loading driver
[ 4.734149] [drm] Initialized nvidia-drm 0.0.0 for 0000:02:00.0 on minor 1
[ 4.734181] input: HDA NVidia HDMI/DP,pcm=7 as /devices/pci0000:00/0000:00:06.3/0000:02:00.1/sound/card0/input18
[ 4.734187] usbcore: registered new interface driver btusb
[ 4.734214] input: HDA NVidia HDMI/DP,pcm=8 as /devices/pci0000:00/0000:00:06.3/0000:02:00.1/sound/card0/input19
[ 4.734244] input: HDA NVidia HDMI/DP,pcm=9 as /devices/pci0000:00/0000:00:06.3/0000:02:00.1/sound/card0/input20
[ 4.735791] Bluetooth: hci0: Device revision is 0
[ 4.735793] Bluetooth: hci0: Secure boot is enabled
[ 4.735794] Bluetooth: hci0: OTP lock is enabled
[ 4.735795] Bluetooth: hci0: API lock is enabled
[ 4.735796] Bluetooth: hci0: Debug lock is disabled
[ 4.735796] Bluetooth: hci0: Minimum firmware build 1 week 10 2014
[ 4.735798] Bluetooth: hci0: Bootloader timestamp 2019.40 buildtype 1 build 38
[ 4.735986] Bluetooth: hci0: DSM reset method type: 0x00
[ 4.738584] Bluetooth: hci0: Found device firmware: intel/ibt-1040-0041.sfi
[ 4.738591] Bluetooth: hci0: Boot Address: 0x100800
[ 4.738592] Bluetooth: hci0: Firmware Version: 200-48.24
[ 4.755172] input: UNIW0001:00 093A:0255 Mouse as /devices/pci0000:80/0000:80:15.3/i2c_designware.3/i2c-4/i2c-UNIW0001:00/0018:093A:0255.0001/input/input21
[ 4.755254] input: UNIW0001:00 093A:0255 Touchpad as /devices/pci0000:80/0000:80:15.3/i2c_designware.3/i2c-4/i2c-UNIW0001:00/0018:093A:0255.0001/input/input22
[ 4.755303] hid-multitouch 0018:093A:0255.0001: input,hidraw0: I2C HID v1.00 Mouse [UNIW0001:00 093A:0255] on i2c-UNIW0001:00

Reported-by: zhangpeng zhangpenga@uniontech.com

Summary by Sourcery

Enable additional hardware support in the deepin_x86_desktop_defconfig for the Deepin 6.12-y kernel.

New Features:

  • Add configuration options to support Intel Ultra 2 I2C HID touchpad devices in the desktop x86 Deepin kernel defconfig.
  • Enable further hardware drivers such as Bluetooth, NVIDIA GPU, NTFS3, and related input/audio components for improved out-of-the-box support on Deepin desktops.

deepin inclusion
category: feature

Tested on DMI: MECHREVO YAOSHI Series/YAOSHI Series-X6AR55xY, BIOS N.1.18MRO24 08/06/2025
case: Intel Ultra 2 i2c touchpad support

Log:
[    4.671551] ntfs3: Warning: Activated 64 bits per cluster. Windows does not support this
[    4.671552] ntfs3: Read-only LZX/Xpress compression included
[    4.676241] nvidia 0000:02:00.0: vgaarb: VGA decodes changed: olddecodes=io+mem,decodes=none:owns=none
[    4.686034] intel-hid INTC10CB:00: failed to enable HID power button
[    4.689088] NVRM: loading NVIDIA UNIX Open Kernel Module for x86_64  580.119.02  Release Build  (dvs-builder@U22-I3-B15-03-5)  Mon Dec  8 07:51:55 UTC 2025
[    4.698028] input: HDA NVidia HDMI/DP,pcm=3 as /devices/pci0000:00/0000:00:06.3/0000:02:00.1/sound/card0/input17
[    4.728742] nvidia-modeset: Loading NVIDIA UNIX Open Kernel Mode Setting Driver for x86_64  580.119.02  Release Build  (dvs-builder@U22-I3-B15-03-5)  Mon Dec  8 07:38:31 UTC 2025
[    4.729475] snd_hda_codec_realtek hdaudioC1D0: autoconfig for ALC274: line_outs=1 (0x17/0x0/0x0/0x0/0x0) type:speaker
[    4.729478] snd_hda_codec_realtek hdaudioC1D0:    speaker_outs=0 (0x0/0x0/0x0/0x0/0x0)
[    4.729479] snd_hda_codec_realtek hdaudioC1D0:    hp_outs=1 (0x21/0x0/0x0/0x0/0x0)
[    4.729480] snd_hda_codec_realtek hdaudioC1D0:    mono: mono_out=0x0
[    4.729481] snd_hda_codec_realtek hdaudioC1D0:    inputs:
[    4.729482] snd_hda_codec_realtek hdaudioC1D0:      Internal Mic=0x12
[    4.729483] snd_hda_codec_realtek hdaudioC1D0:      Headset Mic=0x19
[    4.730400] RPC: Registered named UNIX socket transport module.
[    4.730403] RPC: Registered udp transport module.
[    4.730404] RPC: Registered tcp transport module.
[    4.730404] RPC: Registered tcp-with-tls transport module.
[    4.730405] RPC: Registered tcp NFSv4.1 backchannel transport module.
[    4.734010] [drm] [nvidia-drm] [GPU ID 0x00000200] Loading driver
[    4.734149] [drm] Initialized nvidia-drm 0.0.0 for 0000:02:00.0 on minor 1
[    4.734181] input: HDA NVidia HDMI/DP,pcm=7 as /devices/pci0000:00/0000:00:06.3/0000:02:00.1/sound/card0/input18
[    4.734187] usbcore: registered new interface driver btusb
[    4.734214] input: HDA NVidia HDMI/DP,pcm=8 as /devices/pci0000:00/0000:00:06.3/0000:02:00.1/sound/card0/input19
[    4.734244] input: HDA NVidia HDMI/DP,pcm=9 as /devices/pci0000:00/0000:00:06.3/0000:02:00.1/sound/card0/input20
[    4.735791] Bluetooth: hci0: Device revision is 0
[    4.735793] Bluetooth: hci0: Secure boot is enabled
[    4.735794] Bluetooth: hci0: OTP lock is enabled
[    4.735795] Bluetooth: hci0: API lock is enabled
[    4.735796] Bluetooth: hci0: Debug lock is disabled
[    4.735796] Bluetooth: hci0: Minimum firmware build 1 week 10 2014
[    4.735798] Bluetooth: hci0: Bootloader timestamp 2019.40 buildtype 1 build 38
[    4.735986] Bluetooth: hci0: DSM reset method type: 0x00
[    4.738584] Bluetooth: hci0: Found device firmware: intel/ibt-1040-0041.sfi
[    4.738591] Bluetooth: hci0: Boot Address: 0x100800
[    4.738592] Bluetooth: hci0: Firmware Version: 200-48.24
[    4.755172] input: UNIW0001:00 093A:0255 Mouse as /devices/pci0000:80/0000:80:15.3/i2c_designware.3/i2c-4/i2c-UNIW0001:00/0018:093A:0255.0001/input/input21
[    4.755254] input: UNIW0001:00 093A:0255 Touchpad as /devices/pci0000:80/0000:80:15.3/i2c_designware.3/i2c-4/i2c-UNIW0001:00/0018:093A:0255.0001/input/input22
[    4.755303] hid-multitouch 0018:093A:0255.0001: input,hidraw0: I2C HID v1.00 Mouse [UNIW0001:00 093A:0255] on i2c-UNIW0001:00

Reported-by: zhangpeng <zhangpenga@uniontech.com>
Signed-off-by: Wentao Guan <guanwentao@uniontech.com>
@sourcery-ai
Copy link

sourcery-ai bot commented Dec 26, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Update deepin_x86_desktop_defconfig to enable additional hardware drivers—primarily I2C HID touchpad, audio, Bluetooth, NVIDIA GPU, and storage-related options—to improve compatibility on Intel Ultra 2-based x86 desktop/laptop hardware.

File-Level Changes

Change Details Files
Enable I2C HID and touchpad-related options needed for Intel Ultra 2 I2C touchpads.
  • Turn on I2C HID core support and relevant HID multitouch/input drivers.
  • Select the appropriate Intel/DesignWare I2C controller options used on mobile platforms.
  • Ensure required input subsystem and HID glue options are set so the UNIW0001:00 093A:0255 device enumerates correctly.
arch/x86/configs/deepin_x86_desktop_defconfig
Broaden audio and HDMI/DP sound driver coverage for NVIDIA HDA codecs.
  • Enable/keep enabled HDA codec and NVIDIA HDMI/DP audio options referenced in the boot log.
  • Adjust sound subsystem configs to ensure automatic Realtek ALC274 and NVIDIA HDMI inputs/outputs are available by default.
arch/x86/configs/deepin_x86_desktop_defconfig
Enable or refine Bluetooth support with Intel firmware-based adapters.
  • Enable btusb and necessary Bluetooth HCI/Intel-specific options to match the logged Intel Bluetooth device.
  • Ensure firmware loading support for intel/ibt-* firmware blobs is available in the default config.
arch/x86/configs/deepin_x86_desktop_defconfig
Ensure NVIDIA GPU stack and DRM/KMS configs are compatible with the NVIDIA proprietary/open kernel modules used on Deepin.
  • Adjust DRM and framebuffer-related options so the nvidia-drm KMS module can load cleanly.
  • Avoid conflicting FB/DRM options that could interfere with VGA arbitration for the discrete GPU.
arch/x86/configs/deepin_x86_desktop_defconfig
Tighten general desktop/storage/network feature coverage for Deepin x86 desktop profile.
  • Enable or refine NTFS3 and related storage options (including compression support) for better Windows filesystem interoperability.
  • Confirm core networking/RPC options (e.g., NFSv4.1 backchannel) are included for desktop use-cases.
  • Align miscellaneous platform drivers and power-management options with the tested DMI/BIOS platform.
arch/x86/configs/deepin_x86_desktop_defconfig

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-ci-robot
Copy link

deepin pr auto review

这是一个Linux内核配置文件的diff,主要增加了一些硬件驱动的支持。让我从几个方面来分析这些变更:

  1. 代码质量:
  • 配置项的添加都是规范的,遵循了内核配置的命名规范
  • 相关的配置项被组织在一起,比如MTD、I2C、SPI等设备的配置
  • 每个新增的配置项都正确地使用了=m(模块)或=y(内置)选项
  1. 功能扩展:
  • 增加了对更多MTD设备的支持,如CONFIG_MTD_MCHP48L640
  • 扩展了I2C和SPI控制器的支持,包括更多厂商的控制器
  • 增加了大量新的传感器和ADC设备支持
  • 添加了更多显示面板和DRM驱动的支持
  • 增加了新的音频编解码器支持
  1. 性能考虑:
  • 大部分新增的驱动都配置为模块(m),这样可以按需加载,不会增加内核镜像大小
  • 对于基础功能如GPIO、I2C等核心功能使用内置(y)配置,确保系统稳定性
  1. 安全性:
  • 没有发现明显的安全隐患
  • 驱动模块的添加都是标准的内核驱动,没有自定义或第三方代码

建议:

  1. 考虑对一些不常用的驱动使用模块配置,以减小内核体积
  2. 建议添加配置项的注释,说明添加这些驱动的原因
  3. 对于新增的显示驱动,建议进行兼容性测试
  4. 建议对新增的电源管理相关驱动进行功耗测试

总体来说,这个diff的变更都是合理的,主要是增加了对新硬件的支持,没有发现明显的问题。建议在合并前进行充分的测试,特别是新增的显示和存储相关驱动。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lanlanxiyiji
Once this PR has been reviewed and has the lgtm label, please ask for approval from opsiff. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Consider briefly grouping and annotating the newly enabled config options in the defconfig (e.g., with comments for touchpad/Bluetooth/GPU storage features) so future maintainers can quickly see why each block was enabled for Deepin desktops.
  • Review whether all newly enabled drivers need to be built-in rather than modules, and prefer m where possible to keep the desktop kernel lean and reduce unnecessary memory footprint.
  • Double-check that the new hardware options are constrained to reasonably generic devices (e.g., not overly vendor- or model-specific) to avoid bloating the default desktop config with support that only applies to a single machine line.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider briefly grouping and annotating the newly enabled config options in the defconfig (e.g., with comments for touchpad/Bluetooth/GPU storage features) so future maintainers can quickly see why each block was enabled for Deepin desktops.
- Review whether all newly enabled drivers need to be built-in rather than modules, and prefer `m` where possible to keep the desktop kernel lean and reduce unnecessary memory footprint.
- Double-check that the new hardware options are constrained to reasonably generic devices (e.g., not overly vendor- or model-specific) to avoid bloating the default desktop config with support that only applies to a single machine line.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@lanlanxiyiji lanlanxiyiji merged commit 2321ad2 into deepin-community:linux-6.12.y Dec 26, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants