fix: DH-19912: Fix AG Grid not opening Pivots when wrapped in AgGrid #1259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mofojed
commented
Nov 6, 2025
mofojed
commented
- We should wrap pivot tables in AgGrid for them to work correctly. Should be fixed now.
- We should wrap pivot tables in AgGrid for them to work correctly. Should be fixed now.
mattrunyon
requested changes
Nov 6, 2025
Collaborator
mattrunyon
left a comment
mattrunyon
left a comment
There was a problem hiding this comment.
Just curious why not do the widget type check in Python? Seems like both pivot and normal table widgets are handled the same in the modified code. Is there any reason to throw on the client instead of the server?
- You can fetch and pass a table direct into AgGridView if you want to use it
- I think React v18 update makes the initial loading spinner skip, and it didn't used to
mattrunyon
previously approved these changes
Nov 7, 2025
Comment on lines
+50
to
54
| } | ||
| if (!cancelled) { | ||
| log.info('Loaded table', newTable); | ||
| setTable(newTable); | ||
| } |
Collaborator
There was a problem hiding this comment.
Since there's no server side validation, you could also end up with a Figure here technically. I think it's the only non-generic widget that would hit this. We weren't checking it before, so I'm indifferent here (there's no type field on table, figure, etc. so you have to feature detect)
- We would count the number of panels before we were waiting for the "Panels" button to be visible, which would sometimes be incorrect if the loading spinner had flashed/disappeared - Just count the number of panels right before we click the "Panels" button - deephaven/web-client-ui#2569 should also fix it from UI side, but this fixes the issue on the deephaven-plugins side
mattrunyon
approved these changes
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.