fix: update data generators to be deterministic when columns evaluated in parallel #1240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
plotly-express docs preview (Available for 14 days) |
Member
|
Noting that this will be unnecessary with 0.40.2, as Charles fixed the issue with deephaven/deephaven-core#7255 and deephaven/deephaven-core#7258 |
mofojed
previously approved these changes
Oct 2, 2025
plugins/plotly-express/src/deephaven/plot/express/data/data_generators.py
Outdated
Show resolved
Hide resolved
|
plotly-express docs preview (Available for 14 days) |
mofojed
approved these changes
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to using new rng class instances per random call so that columns getting evaluated in parallel are still deterministic.
Handles DH-20516 failure case from recent change to engine. Also tweak stocks price generation so it doesn't swing negative, and has a tighter range.
Regenerate snapshots.