feat: Deephaven Pivot plugin #1231
Conversation
Co-authored-by: Mike Bender <mikebender@deephaven.io>
Co-authored-by: Mike Bender <mikebender@deephaven.io>
Co-authored-by: Mike Bender <mikebender@deephaven.io>
…lugins into pivot-plugin
|
plotly-express docs preview (Available for 14 days) |
|
plotly-express docs preview (Available for 14 days) |
| import type { dh as DhType } from '@deephaven/jsapi-types'; | ||
| import { Formatter } from '@deephaven/jsapi-utils'; | ||
| import { Delta } from 'plotly.js-dist-min'; | ||
| import Plotly, { type Delta } from 'plotly.js'; |
There was a problem hiding this comment.
For some reason I was getting errors from npm run types:
plugins/plotly-express/src/js/src/PlotlyExpressChartUtils.test.ts:372:23 - error TS2345: Argument of type 'Plotly.Data[]' is not assignable to parameter of type 'import("/Users/vladbabich/dev/deephaven-plugins/plugins/plotly-express/src/js/node_modules/@types/plotly.js/index").Data[]'.
Type 'Plotly.Data' is not assignable to type 'import("/Users/vladbabich/dev/deephaven-plugins/plugins/plotly-express/src/js/node_modules/@types/plotly.js/index").Data'.
Type 'Partial<PlotData>' is not assignable to type 'Data'.
Type 'Partial<PlotData>' is not assignable to type 'Partial<PlotData> | Partial<BoxPlotData>'.
Type 'Partial<PlotData>' is not assignable to type 'Partial<BoxPlotData>'.
Types of property 'type' are incompatible.
Type 'PlotType | undefined' is not assignable to type '"box" | undefined'.
Type '"bar"' is not assignable to type '"box"'.
372 setWebGlTraceType(data, true, webGlTraceIndices);
Had to update this import to fix the types.
|
plotly-express docs preview (Available for 14 days) |
|
plotly-express docs preview (Available for 14 days) |
1 similar comment
|
plotly-express docs preview (Available for 14 days) |
|
plotly-express docs preview (Available for 14 days) |
| get isRootRowExpanded(): boolean { | ||
| return this._isRootRowExpanded; | ||
| } | ||
|
|
||
| set isRootRowExpanded(value: boolean) { | ||
| this.pendingIsRootRowExpanded = value; | ||
| } |
There was a problem hiding this comment.
Hrmmm so we allow setting the property, but the value we return is still going to be the old value until the next pivot update is received... is there no way to derive this state from the viewport data itself/looking at the keys and such? Seems kind of gross to have to track an intermediate variable.
There was a problem hiding this comment.
The viewport data doesn't have an indication of the root row/column state. I asked about this in the Pivots Slack channel on Sept. 11, Colin suggested the client could keep track of the state.
|
plotly-express docs preview (Available for 14 days) |
2 participants
No description provided.