DH to work with byte arrays#4507
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
nbauernfeind
left a comment
There was a problem hiding this comment.
Please sign the CLA (see the automated message above).
Once you do and address my comments, I'll kick of a "nightly" build which runs a suite of tests (many of which go through the ChunkInputStreamGenerator code path).
Thank you for the PR; once merged I'll probably tack on support for the remaining primitive arrays. (No reason the java client shouldn't be supporting these.)
...s/barrage/src/main/java/io/deephaven/extensions/barrage/chunk/ChunkInputStreamGenerator.java
Show resolved
Hide resolved
java-client/flight-examples/src/main/java/io/deephaven/client/examples/AddToInputTable.java
Outdated
Show resolved
Hide resolved
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
|
Your PR looks good to me so far. I've just kicked off that suite of tests. When they pass (plus or minus a known random failure) then I'll get this merged. Thank you so much for your contribution! Here is the CI link if you are curious: https://github.com/nbauernfeind/deephaven-core/actions/runs/6227600752/ |
|
Labels indicate documentation is required. Issues for documentation have been opened: How-to: https://github.com/deephaven/deephaven.io/issues/3202 |
Fixes #4355.
This is currently a very rough hack, but it does work locally. Not sure what it breaks.