-
Notifications
You must be signed in to change notification settings - Fork 32
Update dependencies to latest version #117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I jumped the gun on my review. We need to make sure the Minimal Versions still pass. Usually this means bumping patch versions on the version specifier for the crate in question (or the crate that introduced a transitive dependency that isn't building). Occasionally, it means adding a version override the the transitive dependency directly. See the section beginning on line 44 of Cargo.toml
We use cargo tree -i
(built into cargo) and cargo minimal-versions
(Gotten with cargo install cargo-minimal-versions
) to help figure out what needs adjusting.
3bacf63
to
edccf7b
Compare
Thanks for the comments. I've amend the commit I run the minimal version test locally and it works. I hope it passes on CI system as well.. |
It looks like the Clippy check is failing on this PR after the CI checks were run. |
It seems that rust version got update and in 1.88 new errors were showing up. They are fixed not. The error complaining about the error variant size is still present. this is fixed in #115 |
#115 is merged now. Can you rebase this PR, and (optionally) fix the fmt issues if they're still showing up? |
45b50f3
to
debc682
Compare
debc682
to
0e7a247
Compare
Done, thanks for merging #115. Also fixed format. |
Changes were made. Trying to get CI running again.
CI is now running again here: https://github.com/deepgram/deepgram-rust-sdk/actions/runs/16197851369 |
Test passed! |
Uh oh!
There was an error while loading. Please reload this page.