Skip to content

Update dependencies to latest version #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 11, 2025

Conversation

jcaden
Copy link
Contributor

@jcaden jcaden commented Jun 29, 2025


@jpvajda jpvajda requested a review from jcdyer June 30, 2025 16:39
jcdyer
jcdyer previously requested changes Jun 30, 2025
Copy link
Contributor

@jcdyer jcdyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I jumped the gun on my review. We need to make sure the Minimal Versions still pass. Usually this means bumping patch versions on the version specifier for the crate in question (or the crate that introduced a transitive dependency that isn't building). Occasionally, it means adding a version override the the transitive dependency directly. See the section beginning on line 44 of Cargo.toml

We use cargo tree -i (built into cargo) and cargo minimal-versions (Gotten with cargo install cargo-minimal-versions) to help figure out what needs adjusting.

@jcaden jcaden force-pushed the update_dependencies branch from 3bacf63 to edccf7b Compare July 1, 2025 12:47
@jcaden
Copy link
Contributor Author

jcaden commented Jul 1, 2025

Thanks for the comments. I've amend the commit I run the minimal version test locally and it works. I hope it passes on CI system as well..

@jpvajda jpvajda requested a review from jcdyer July 7, 2025 22:04
@jpvajda
Copy link
Contributor

jpvajda commented Jul 9, 2025

It looks like the Clippy check is failing on this PR after the CI checks were run.

@jcaden
Copy link
Contributor Author

jcaden commented Jul 10, 2025

It seems that rust version got update and in 1.88 new errors were showing up. They are fixed not. The error complaining about the error variant size is still present. this is fixed in #115

@jcdyer
Copy link
Contributor

jcdyer commented Jul 10, 2025

#115 is merged now. Can you rebase this PR, and (optionally) fix the fmt issues if they're still showing up?

@jcaden jcaden force-pushed the update_dependencies branch from 45b50f3 to debc682 Compare July 10, 2025 14:26
@jcaden jcaden force-pushed the update_dependencies branch from debc682 to 0e7a247 Compare July 10, 2025 14:27
@jcaden
Copy link
Contributor Author

jcaden commented Jul 10, 2025

Done, thanks for merging #115. Also fixed format.

@jpvajda jpvajda self-requested a review July 10, 2025 17:10
@jcdyer jcdyer dismissed their stale review July 11, 2025 21:18

Changes were made. Trying to get CI running again.

@jcdyer
Copy link
Contributor

jcdyer commented Jul 11, 2025

@jcdyer
Copy link
Contributor

jcdyer commented Jul 11, 2025

Test passed!

@jcdyer jcdyer merged commit 1156e0c into deepgram:main Jul 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants