Skip to content

Conversation

@TejasMorbagal
Copy link
Member

@TejasMorbagal TejasMorbagal commented Apr 9, 2025

This implemetation supports forking of open-science-catalog-metadata-staging, open-science-catalog-metadata-testing
and open-science-catalog-metadata (default) base on the input parameter 'environment'

Copy link
Collaborator

@thomasstorm thomasstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but please see comment.

Comment on lines 15 to 20
@click.option(
"--environment",
type=click.Choice(["production", "staging", "testing"], case_sensitive=False),
default="production",
help="Target environment for publishing (production, staging, testing)",
)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, but don't you need to add -e as possibility, according to the readme? Or is this added by default?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thanks for spotting it. Added now and testing works!

@TejasMorbagal TejasMorbagal merged commit ca54122 into main Apr 9, 2025
1 check passed
@TejasMorbagal TejasMorbagal deleted the tejas-xxx-support-publish-to-testing-and-staging branch April 9, 2025 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants