-
Notifications
You must be signed in to change notification settings - Fork 1
Implementation of publish experiment feature and variable STAC catalog generation for each variable in the dataset #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3 +/- ##
==========================================
- Coverage 90.82% 86.32% -4.50%
==========================================
Files 13 17 +4
Lines 665 929 +264
==========================================
+ Hits 604 802 +198
- Misses 61 127 +66 ☔ View full report in Codecov by Sentry. |
forman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall nice work. Clean and comprehensive code.
Co-authored-by: Norman Fomferra <norman.fomferra@brockmann-consult.de>
Co-authored-by: Norman Fomferra <norman.fomferra@brockmann-consult.de>
This PR implements
Note that 'gcmd_keyword_url' is expected as variable metadata if the variable in the dataset doesn't have a corresponding catalog already in OSC.