Skip to content

Conversation

@TejasMorbagal
Copy link
Member

This PR implements

  1. variable STAC catalog generation for each variable in the dataset.
  2. publish experiment cli and method

Note that 'gcmd_keyword_url' is expected as variable metadata if the variable in the dataset doesn't have a corresponding catalog already in OSC.

@TejasMorbagal TejasMorbagal requested a review from forman January 21, 2025 10:02
@codecov
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 77.61194% with 75 lines in your changes missing coverage. Please review.

Project coverage is 86.32%. Comparing base (c363d08) to head (5503cd8).
Report is 22 commits behind head on main.

Files with missing lines Patch % Lines
deep_code/tools/publish.py 60.97% 32 Missing ⚠️
deep_code/utils/dataset_stac_generator.py 47.36% 30 Missing ⚠️
deep_code/cli/publish.py 0.00% 7 Missing ⚠️
deep_code/utils/github_automation.py 33.33% 4 Missing ⚠️
deep_code/cli/main.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #3      +/-   ##
==========================================
- Coverage   90.82%   86.32%   -4.50%     
==========================================
  Files          13       17       +4     
  Lines         665      929     +264     
==========================================
+ Hits          604      802     +198     
- Misses         61      127      +66     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@forman forman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall nice work. Clean and comprehensive code.

@TejasMorbagal TejasMorbagal merged commit 36b52d4 into main Jan 27, 2025
1 of 3 checks passed
@TejasMorbagal TejasMorbagal deleted the tejas-xxx-publish-experiment-feature branch January 27, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants