Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code review #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
"babel-preset-stage-1": "^6.1.18",
"lodash": "^3.10.1",
"react": "^0.14.3",
"react-addons-shallow-compare": "^15.4.2",
"react-dates": "^7.0.1",
"react-dom": "^0.14.3",
"react-google-maps": "^6.0.1",
Expand Down
1 change: 1 addition & 0 deletions public/js/main.js
Original file line number Diff line number Diff line change
Expand Up @@ -88,3 +88,4 @@ $(document).ready(function ()
$("#panelCrear").hide();
});
});
//Chevere la paginación
1 change: 1 addition & 0 deletions public/js/map.js
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ function initMap()
}
}
}
//Chevere el uso del google maps API
// function initMap() {
// map = new google.maps.Map(document.getElementById('map'), {
// center: { lat: 20, lng: -160 },
Expand Down
1 change: 1 addition & 0 deletions src/components/app.js
Original file line number Diff line number Diff line change
Expand Up @@ -93,3 +93,4 @@ class App extends Component {
}

export default App;
//Muy ordenado y bien hecho
1 change: 1 addition & 0 deletions src/components/crime_adder.js
Original file line number Diff line number Diff line change
Expand Up @@ -136,3 +136,4 @@ class CrimeAdder extends Component {
}

export default CrimeAdder;
//Ordenado y bien hecho
4 changes: 3 additions & 1 deletion src/components/crime_displayer.js
Original file line number Diff line number Diff line change
Expand Up @@ -138,4 +138,6 @@ class CrimeDisplayer extends Component {
}
}

export default CrimeDisplayer;
export default CrimeDisplayer; //ojo la indentacion

//en general ordenado y bien hecho
1 change: 1 addition & 0 deletions src/components/crime_map.js
Original file line number Diff line number Diff line change
Expand Up @@ -93,3 +93,4 @@ class CrimeMap extends Component {
}

export default CrimeMap;
//Bien, ordenada la separacion dela clase y el listener del map
1 change: 1 addition & 0 deletions src/components/crime_selector.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,3 +30,4 @@ CrimeSelector.propTypes = {
};

export default CrimeSelector;
//Ordenado, cort, concreto. Bueno especificar los tipos de los atributos props
1 change: 1 addition & 0 deletions src/components/crime_type_selector.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,3 +28,4 @@ CrimeTypeSelector.propTypes = {
};

export default CrimeTypeSelector;
//Ordenado, cort, concreto. Bueno especificar los tipos de los atributos props
1 change: 1 addition & 0 deletions src/components/description.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,3 +25,4 @@ Description.propTypes = {
};

export default Description;
//Ordenado, cort, concreto. Bueno especificar los tipos de los atributos props
1 change: 1 addition & 0 deletions src/components/reported_selector.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,3 +30,4 @@ ReportedSelector.propTypes = {
};

export default ReportedSelector;
//Ordenado, cort, concreto. Bueno especificar los tipos de los atributos props
1 change: 1 addition & 0 deletions src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,4 @@ import App from './components/app';


ReactDOM.render(<App/>, document.querySelector('.react'));
//Bien