Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed exception code and status code of response when non existent lock is requested #702

Merged
merged 3 commits into from
Aug 30, 2016

Conversation

dstenger
Copy link
Contributor

@dstenger dstenger commented Jun 3, 2016

This fix targets the locking functionality of WFS 2.0.0.

Previously, when LockFeature was requested with a non existent lockId, the WFS 2.0.0 threw an InvalidParameterValue exception with status code 400.

The specification says that following is expected:

  • status code: 403
  • exception code: LockHasExpired

Excerpt from WFS 2.0.0 specification:

12.2.4.2 lockId parameter

A lockId parameter specified within a LockFeature operations shall be used to reset the expiry time of an existing lock.
...
Such a LockFeature operation shall be executed before the specified lock has expired; otherwise the server shall raise a LockHasExpired exception (see Table 3).
...

This fix corrects the status and exception codes to implement the expected behaviour.

In addition, deegree now passes following tests of the CITE WFS 2.0 test suite (Locking CC) [1]:

  • "Reset Nonexistent Lock"
  • "Lock All Query Results_20 Seconds"

[1] http://cite.opengeospatial.org/teamengine/

@dstenger dstenger added bug error issue and bug (fix) in progress labels Jun 3, 2016
@tfr42 tfr42 added this to the 3.4 milestone Jun 10, 2016
@copierrj copierrj added the needs rebase PR is not up to date and needs rebase label Aug 17, 2016
@lgoltz lgoltz removed the needs rebase PR is not up to date and needs rebase label Aug 22, 2016
@copierrj copierrj merged commit cd4b7c3 into deegree:master Aug 30, 2016
@lgoltz lgoltz deleted the exceptionLockHasExpired-3483 branch December 8, 2022 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug error issue and bug (fix)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants