Fix buffer issue when response buffering is active and a short results #1619
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #1618 I found this issue, that when response buffering is active, a single record CSV output was suppressed.
This was boiling down to the point that a Writer was created in
HttpResponseBuffer
but not flushed whenflushBuffer()
is called like it is done for thexmlWriter
.To work around the issue of a possible closed writer instead of
flush()
, which raises an exception on an already closed stream, thecheckError()
was used which only flushes if the writer is still open (see [1]).References: