Conversation
# Conflicts: # packages/create-typink/templates/legacy-subconnectv2-nextjs/package.json
Member
Author
|
Merging this for now, we'll also need to update the templates to use this new |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This work add a generic abstraction for tx toaster. The
txToastercore logic now will be move totypinkpackage. So dapp can import and use.We also implement adapters for popular toaster libraries (sonnet, react-toastify and react-hot-toast) so we can set this up easily via the
setupTxToastermethod with other customizations.E.g:
The
ToastAdapterinterface is keep minimal so devs can implement new different implement for other toast libraries as needed.A demo to support multiple toast library in
examples/demo-generaldapp.