Move IPCMessageStart enum into it own file with security team OWNERS,…

… so that new message files can't be added to chromium without triggering a security review.

Review URL: https://chromiumcodereview.appspot.com/11048038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163713 0039d316-1c4b-4281-b951-d872f2087c98

chrome/common/all_messages.h

@@ -3,11 +3,12 @@
 // found in the LICENSE file.
 
 // Multiply-included file, hence no include guard.
-// Inclusion of all message files present in chrome.  Keep this file
-// up-to-date when adding a new value to enum IPCMessageStart in
-// ipc/ipc_message_utils.h to include the corresponding message file.
-// Messages classes used exclusively outside of chrome should instead get an
-// exemption in chrome/tools/ipclist/ipclist.cc.
+// Inclusion of all message files present in chrome. Keep this file
+// up-to-date when adding a new value to the IPCMessageStart enum in
+// ipc/ipc_message_start.h to ensure the corresponding message file is
+// included here. Message classes used exclusively outside of chrome
+// should not be listed here and instead get an exemption in
+// chrome/tools/ipclist/ipclist.cc.
 #if !defined(OS_ANDROID)
 #include "chrome/browser/importer/profile_import_process_messages.h"
 #endif

ipc/OWNERS

@@ -7,3 +7,12 @@ tsepez@chromium.org
 
 # For NaCl-related code (ipc_channel_nacl.*)
 dmichael@chromium.org
+
+# New IPC message files require a security review to avoid introducing
+# new sandbox escapes.
+per-file ipc_message_start.h=set noparent
+per-file ipc_message_start.h=cdn@chromium.org
+per-file ipc_message_start.h=jln@chromium.org
+per-file ipc_message_start.h=jschuh@chromium.org
+per-file ipc_message_start.h=palmer@chromium.org
+per-file ipc_message_start.h=tsepez@chromium.org

ipc/ipc.gypi

@@ -36,6 +36,7 @@
           'ipc_message.cc',
           'ipc_message.h',
           'ipc_message_macros.h',
+          'ipc_message_start.h',
           'ipc_message_utils.cc',
           'ipc_message_utils.h',
           'ipc_param_traits.h',

ipc/ipc_message_macros.h

@@ -15,7 +15,7 @@
 //
 // Each XXX_messages.h file must be registered with the IPC system.  This
 // requires adding two things:
-//   - An XXXMsgStart value to the IPCMessageStart enum in ipc_message_utils.h
+//   - An XXXMsgStart value to the IPCMessageStart enum in ipc_message_start.h
 //   - An inclusion of XXX_messages.h file in a message generator .h file
 //
 // The XXXMsgStart value is an enumeration that ensures uniqueness for

ipc/ipc_message_start.h

@@ -0,0 +1,77 @@
+// Copyright 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef IPC_IPC_MESSAGE_START_H_
+#define IPC_IPC_MESSAGE_START_H_
+
+// Used by IPC_BEGIN_MESSAGES so that each message class starts from a unique
+// base.  Messages have unique IDs across channels in order for the IPC logging
+// code to figure out the message class from its ID.
+enum IPCMessageStart {
+  AutomationMsgStart = 0,
+  ViewMsgStart,
+  PluginMsgStart,
+  ProfileImportMsgStart,
+  TestMsgStart,
+  DevToolsMsgStart,
+  WorkerMsgStart,
+  NaClMsgStart,
+  UtilityMsgStart,
+  GpuMsgStart,
+  ServiceMsgStart,
+  PpapiMsgStart,
+  FirefoxImporterUnittestMsgStart,
+  FileUtilitiesMsgStart,
+  MimeRegistryMsgStart,
+  DatabaseMsgStart,
+  DOMStorageMsgStart,
+  IndexedDBMsgStart,
+  PepperFileMsgStart,
+  SpeechRecognitionMsgStart,
+  PepperMsgStart,
+  AutofillMsgStart,
+  SafeBrowsingMsgStart,
+  P2PMsgStart,
+  SocketStreamMsgStart,
+  ResourceMsgStart,
+  FileSystemMsgStart,
+  ChildProcessMsgStart,
+  ClipboardMsgStart,
+  BlobMsgStart,
+  AppCacheMsgStart,
+  DeviceMotionMsgStart,
+  DeviceOrientationMsgStart,
+  DesktopNotificationMsgStart,
+  GeolocationMsgStart,
+  AudioMsgStart,
+  ChromeMsgStart,
+  DragMsgStart,
+  PrintMsgStart,
+  SpellCheckMsgStart,
+  ExtensionMsgStart,
+  VideoCaptureMsgStart,
+  QuotaMsgStart,
+  IconMsgStart,
+  TextInputClientMsgStart,
+  ChromeUtilityMsgStart,
+  MediaStreamMsgStart,
+  ChromeBenchmarkingMsgStart,
+  IntentsMsgStart,
+  JavaBridgeMsgStart,
+  GamepadMsgStart,
+  ShellMsgStart,
+  AccessibilityMsgStart,
+  PrerenderMsgStart,
+  ChromotingMsgStart,
+  OldBrowserPluginMsgStart,
+  BrowserPluginMsgStart,
+  HyphenatorMsgStart,
+  AndroidWebViewMsgStart,
+  MetroViewerMsgStart,
+  CCMsgStart,
+  MediaPlayerMsgStart,
+  LastIPCMsgStart      // Must come last.
+};
+
+#endif  // IPC_IPC_MESSAGE_START_H_

ipc/ipc_message_utils.h

@@ -17,6 +17,7 @@
 #include "base/stringprintf.h"
 #include "base/string_util.h"
 #include "base/tuple.h"
+#include "ipc/ipc_message_start.h"
 #include "ipc/ipc_param_traits.h"
 #include "ipc/ipc_sync_message.h"
 
@@ -43,75 +44,6 @@
 #error "Please add the noinline property for your new compiler here."
 #endif
 
-// Used by IPC_BEGIN_MESSAGES so that each message class starts from a unique
-// base.  Messages have unique IDs across channels in order for the IPC logging
-// code to figure out the message class from its ID.
-enum IPCMessageStart {
-  AutomationMsgStart = 0,
-  ViewMsgStart,
-  PluginMsgStart,
-  ProfileImportMsgStart,
-  TestMsgStart,
-  DevToolsMsgStart,
-  WorkerMsgStart,
-  NaClMsgStart,
-  UtilityMsgStart,
-  GpuMsgStart,
-  ServiceMsgStart,
-  PpapiMsgStart,
-  FirefoxImporterUnittestMsgStart,
-  FileUtilitiesMsgStart,
-  MimeRegistryMsgStart,
-  DatabaseMsgStart,
-  DOMStorageMsgStart,
-  IndexedDBMsgStart,
-  PepperFileMsgStart,
-  SpeechRecognitionMsgStart,
-  PepperMsgStart,
-  AutofillMsgStart,
-  SafeBrowsingMsgStart,
-  P2PMsgStart,
-  SocketStreamMsgStart,
-  ResourceMsgStart,
-  FileSystemMsgStart,
-  ChildProcessMsgStart,
-  ClipboardMsgStart,
-  BlobMsgStart,
-  AppCacheMsgStart,
-  DeviceMotionMsgStart,
-  DeviceOrientationMsgStart,
-  DesktopNotificationMsgStart,
-  GeolocationMsgStart,
-  AudioMsgStart,
-  ChromeMsgStart,
-  DragMsgStart,
-  PrintMsgStart,
-  SpellCheckMsgStart,
-  ExtensionMsgStart,
-  VideoCaptureMsgStart,
-  QuotaMsgStart,
-  IconMsgStart,
-  TextInputClientMsgStart,
-  ChromeUtilityMsgStart,
-  MediaStreamMsgStart,
-  ChromeBenchmarkingMsgStart,
-  IntentsMsgStart,
-  JavaBridgeMsgStart,
-  GamepadMsgStart,
-  ShellMsgStart,
-  AccessibilityMsgStart,
-  PrerenderMsgStart,
-  ChromotingMsgStart,
-  OldBrowserPluginMsgStart,
-  BrowserPluginMsgStart,
-  HyphenatorMsgStart,
-  AndroidWebViewMsgStart,
-  MetroViewerMsgStart,
-  CCMsgStart,
-  MediaPlayerMsgStart,
-  LastIPCMsgStart      // Must come last.
-};
-
 class FilePath;
 class NullableString16;