Skip to content

Commit

Permalink
Replacing the OVERRIDE with override and FINAL with final in cloud_print
Browse files Browse the repository at this point in the history
This step is a giant search and replace for OVERRIDE and FINAL to
replace them with their lowercase versions.

BUG=417463

Review URL: https://codereview.chromium.org/630753002

Cr-Commit-Position: refs/heads/master@{#298210}
  • Loading branch information
mohan-486 authored and Commit bot committed Oct 6, 2014
1 parent 889350d commit de3401d
Show file tree
Hide file tree
Showing 11 changed files with 61 additions and 61 deletions.
2 changes: 1 addition & 1 deletion cloud_print/gcp20/prototype/cloud_print_request.h
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ class CloudPrintRequest : public net::URLFetcherDelegate,
Delegate* delegate);

// net::URLFetcherDelegate methods:
virtual void OnURLFetchComplete(const net::URLFetcher* source) OVERRIDE;
virtual void OnURLFetchComplete(const net::URLFetcher* source) override;

// Method for handling timeout.
void OnRequestTimeout();
Expand Down
14 changes: 7 additions & 7 deletions cloud_print/gcp20/prototype/cloud_print_requester.h
Original file line number Diff line number Diff line change
Expand Up @@ -134,20 +134,20 @@ class CloudPrintRequester : public base::SupportsWeakPtr<CloudPrintRequester>,
typedef base::Callback<void(const std::string&)> ParserCallback;

// CloudPrintRequester::Delegate methods:
virtual void OnFetchComplete(const std::string& response) OVERRIDE;
virtual void OnFetchComplete(const std::string& response) override;
virtual void OnFetchError(const std::string& server_api,
int server_code,
int server_http_code) OVERRIDE;
virtual void OnFetchTimeoutReached() OVERRIDE;
int server_http_code) override;
virtual void OnFetchTimeoutReached() override;

// gaia::GaiaOAuthClient::Delegate methods:
virtual void OnGetTokensResponse(const std::string& refresh_token,
const std::string& access_token,
int expires_in_seconds) OVERRIDE;
int expires_in_seconds) override;
virtual void OnRefreshTokenResponse(const std::string& access_token,
int expires_in_seconds) OVERRIDE;
virtual void OnOAuthError() OVERRIDE;
virtual void OnNetworkError(int response_code) OVERRIDE;
int expires_in_seconds) override;
virtual void OnOAuthError() override;
virtual void OnNetworkError(int response_code) override;

// Creates GET request.
scoped_ptr<CloudPrintRequest> CreateGet(const GURL& url,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@ class CloudPrintURLRequestContextGetter : public net::URLRequestContextGetter {
scoped_refptr<base::SingleThreadTaskRunner> task_runner);

// URLRequestContextGetter implementation.
virtual net::URLRequestContext* GetURLRequestContext() OVERRIDE;
virtual net::URLRequestContext* GetURLRequestContext() override;

virtual scoped_refptr<base::SingleThreadTaskRunner>
GetNetworkTaskRunner() const OVERRIDE;
GetNetworkTaskRunner() const override;

private:
virtual ~CloudPrintURLRequestContextGetter();
Expand Down
8 changes: 4 additions & 4 deletions cloud_print/gcp20/prototype/cloud_print_xmpp_listener.h
Original file line number Diff line number Diff line change
Expand Up @@ -75,12 +75,12 @@ class CloudPrintXmppListener

private:
// notifier::PushClientObserver methods:
virtual void OnNotificationsEnabled() OVERRIDE;
virtual void OnNotificationsEnabled() override;
virtual void OnNotificationsDisabled(
notifier::NotificationsDisabledReason reason) OVERRIDE;
notifier::NotificationsDisabledReason reason) override;
virtual void OnIncomingNotification(
const notifier::Notification& notification) OVERRIDE;
virtual void OnPingResponse() OVERRIDE;
const notifier::Notification& notification) override;
virtual void OnPingResponse() override;

// Stops listening and sending pings.
void Disconnect();
Expand Down
68 changes: 34 additions & 34 deletions cloud_print/gcp20/prototype/printer.h
Original file line number Diff line number Diff line change
Expand Up @@ -55,77 +55,77 @@ class Printer : public base::SupportsWeakPtr<Printer>,

// PrivetHttpServer::Delegate methods:
virtual PrivetHttpServer::RegistrationErrorStatus RegistrationStart(
const std::string& user) OVERRIDE;
const std::string& user) override;
virtual PrivetHttpServer::RegistrationErrorStatus RegistrationGetClaimToken(
const std::string& user,
std::string* token,
std::string* claim_url) OVERRIDE;
std::string* claim_url) override;
virtual PrivetHttpServer::RegistrationErrorStatus RegistrationComplete(
const std::string& user,
std::string* device_id) OVERRIDE;
std::string* device_id) override;
virtual PrivetHttpServer::RegistrationErrorStatus RegistrationCancel(
const std::string& user) OVERRIDE;
virtual void GetRegistrationServerError(std::string* description) OVERRIDE;
virtual void CreateInfo(PrivetHttpServer::DeviceInfo* info) OVERRIDE;
virtual bool IsRegistered() const OVERRIDE;
virtual bool IsLocalPrintingAllowed() const OVERRIDE;
virtual bool CheckXPrivetTokenHeader(const std::string& token) const OVERRIDE;
virtual const base::DictionaryValue& GetCapabilities() OVERRIDE;
const std::string& user) override;
virtual void GetRegistrationServerError(std::string* description) override;
virtual void CreateInfo(PrivetHttpServer::DeviceInfo* info) override;
virtual bool IsRegistered() const override;
virtual bool IsLocalPrintingAllowed() const override;
virtual bool CheckXPrivetTokenHeader(const std::string& token) const override;
virtual const base::DictionaryValue& GetCapabilities() override;
virtual LocalPrintJob::CreateResult CreateJob(
const std::string& ticket,
std::string* job_id,
int* expires_in,
int* error_timeout,
std::string* error_description) OVERRIDE;
std::string* error_description) override;
virtual LocalPrintJob::SaveResult SubmitDoc(
const LocalPrintJob& job,
std::string* job_id,
int* expires_in,
std::string* error_description,
int* timeout) OVERRIDE;
int* timeout) override;
virtual LocalPrintJob::SaveResult SubmitDocWithId(
const LocalPrintJob& job,
const std::string& job_id,
int* expires_in,
std::string* error_description,
int* timeout) OVERRIDE;
int* timeout) override;
virtual bool GetJobState(const std::string& id,
LocalPrintJob::Info* info) OVERRIDE;
LocalPrintJob::Info* info) override;

// CloudRequester::Delegate methods:
virtual void OnRegistrationStartResponseParsed(
const std::string& registration_token,
const std::string& complete_invite_url,
const std::string& device_id) OVERRIDE;
const std::string& device_id) override;
virtual void OnRegistrationFinished(
const std::string& refresh_token,
const std::string& access_token,
int access_token_expires_in_seconds) OVERRIDE;
virtual void OnXmppJidReceived(const std::string& xmpp_jid) OVERRIDE;
int access_token_expires_in_seconds) override;
virtual void OnXmppJidReceived(const std::string& xmpp_jid) override;
virtual void OnAccesstokenReceviced(const std::string& access_token,
int expires_in_seconds) OVERRIDE;
virtual void OnRegistrationError(const std::string& description) OVERRIDE;
virtual void OnNetworkError() OVERRIDE;
virtual void OnServerError(const std::string& description) OVERRIDE;
virtual void OnAuthError() OVERRIDE;
virtual std::string GetAccessToken() OVERRIDE;
int expires_in_seconds) override;
virtual void OnRegistrationError(const std::string& description) override;
virtual void OnNetworkError() override;
virtual void OnServerError(const std::string& description) override;
virtual void OnAuthError() override;
virtual std::string GetAccessToken() override;
virtual void OnPrintJobsAvailable(
const std::vector<cloud_print_response_parser::Job>& jobs) OVERRIDE;
const std::vector<cloud_print_response_parser::Job>& jobs) override;
virtual void OnPrintJobDownloaded(
const cloud_print_response_parser::Job& job) OVERRIDE;
virtual void OnPrintJobDone() OVERRIDE;
const cloud_print_response_parser::Job& job) override;
virtual void OnPrintJobDone() override;
virtual void OnLocalSettingsReceived(
LocalSettings::State state,
const LocalSettings& settings) OVERRIDE;
virtual void OnLocalSettingsUpdated() OVERRIDE;
const LocalSettings& settings) override;
virtual void OnLocalSettingsUpdated() override;

// CloudPrintXmppListener::Delegate methods:
virtual void OnXmppConnected() OVERRIDE;
virtual void OnXmppAuthError() OVERRIDE;
virtual void OnXmppNetworkError() OVERRIDE;
virtual void OnXmppNewPrintJob(const std::string& device_id) OVERRIDE;
virtual void OnXmppNewLocalSettings(const std::string& device_id) OVERRIDE;
virtual void OnXmppDeleteNotification(const std::string& device_id) OVERRIDE;
virtual void OnXmppConnected() override;
virtual void OnXmppAuthError() override;
virtual void OnXmppNetworkError() override;
virtual void OnXmppNewPrintJob(const std::string& device_id) override;
virtual void OnXmppNewLocalSettings(const std::string& device_id) override;
virtual void OnXmppDeleteNotification(const std::string& device_id) override;

// Method for trying to reconnecting to server on start or after network fail.
void TryConnect();
Expand Down
10 changes: 5 additions & 5 deletions cloud_print/gcp20/prototype/privet_http_server.h
Original file line number Diff line number Diff line change
Expand Up @@ -141,16 +141,16 @@ class PrivetHttpServer: public net::HttpServer::Delegate {

private:
// net::HttpServer::Delegate methods:
virtual void OnConnect(int connection_id) OVERRIDE {}
virtual void OnConnect(int connection_id) override {}
virtual void OnHttpRequest(
int connection_id,
const net::HttpServerRequestInfo& info) OVERRIDE;
const net::HttpServerRequestInfo& info) override;
virtual void OnWebSocketRequest(
int connection_id,
const net::HttpServerRequestInfo& info) OVERRIDE;
const net::HttpServerRequestInfo& info) override;
virtual void OnWebSocketMessage(int connection_id,
const std::string& data) OVERRIDE;
virtual void OnClose(int connection_id) OVERRIDE;
const std::string& data) override;
virtual void OnClose(int connection_id) override;

// Sends error as response. Invoked when request method is invalid.
void ReportInvalidMethod(int connection_id);
Expand Down
4 changes: 2 additions & 2 deletions cloud_print/service/service_state.cc
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ const int64 kRequestTimeoutMs = 10 * 1000;

class ServiceStateURLRequestDelegate : public net::URLRequest::Delegate {
public:
virtual void OnResponseStarted(net::URLRequest* request) OVERRIDE {
virtual void OnResponseStarted(net::URLRequest* request) override {
if (request->GetResponseCode() == 200) {
Read(request);
if (request->status().is_io_pending())
Expand All @@ -48,7 +48,7 @@ class ServiceStateURLRequestDelegate : public net::URLRequest::Delegate {
}

virtual void OnReadCompleted(net::URLRequest* request,
int bytes_read) OVERRIDE {
int bytes_read) override {
Read(request);
if (!request->status().is_io_pending())
base::MessageLoop::current()->Quit();
Expand Down
2 changes: 1 addition & 1 deletion cloud_print/service/win/chrome_launcher.h
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ class ChromeLauncher : public base::DelegateSimpleThread::Delegate {
bool Start();
void Stop();

virtual void Run() OVERRIDE;
virtual void Run() override;

static std::string CreateServiceStateFile(
const std::string& proxy_id,
Expand Down
2 changes: 1 addition & 1 deletion cloud_print/service/win/cloud_print_service_config.cc
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ class SetupDialog : public base::RefCounted<SetupDialog>,
virtual ~Dispatcher() {};

// MessagePumpDispatcher:
virtual uint32_t Dispatch(const MSG& msg) OVERRIDE {
virtual uint32_t Dispatch(const MSG& msg) override {
MSG msg2 = msg;
uint32_t action = POST_DISPATCH_NONE;
if (!dialog_->IsDialogMessage(&msg2))
Expand Down
4 changes: 2 additions & 2 deletions cloud_print/service/win/service_listener.h
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ class ServiceListener : public IPC::Listener {
explicit ServiceListener(const base::FilePath& user_data_dir);
virtual ~ServiceListener();

virtual bool OnMessageReceived(const IPC::Message& msg) OVERRIDE;
virtual void OnChannelConnected(int32 peer_pid) OVERRIDE;
virtual bool OnMessageReceived(const IPC::Message& msg) override;
virtual void OnChannelConnected(int32 peer_pid) override;

private:
void Disconnect();
Expand Down
4 changes: 2 additions & 2 deletions cloud_print/service/win/setup_listener.h
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ class SetupListener : public IPC::Listener {
explicit SetupListener(const base::string16& user);
virtual ~SetupListener();

virtual bool OnMessageReceived(const IPC::Message& msg) OVERRIDE;
virtual void OnChannelError() OVERRIDE;
virtual bool OnMessageReceived(const IPC::Message& msg) override;
virtual void OnChannelError() override;

bool WaitResponce(const base::TimeDelta& delta);

Expand Down

0 comments on commit de3401d

Please sign in to comment.