Skip to content

Commit

Permalink
Refactor libjingle.gyp:
Browse files Browse the repository at this point in the history
* Move code out of libjingle_p2p and libjingle_peerconnection into the libjingle lib.
* Update gyp files that previously depended on libjingle_p2p to depend on libjingle.
* Only the constant files are left in the extra libs (which is why they exist).
* Move the webrtc code out into a separate target.

Review URL: https://codereview.chromium.org/12465002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186277 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
tommi@chromium.org committed Mar 5, 2013
1 parent 98e97d0 commit 5f8d33a
Show file tree
Hide file tree
Showing 5 changed files with 121 additions and 101 deletions.
3 changes: 1 addition & 2 deletions content/content_renderer.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -336,8 +336,7 @@
}],
['enable_webrtc==1', {
'dependencies': [
'../third_party/libjingle/libjingle.gyp:libjingle_p2p',
'../third_party/libjingle/libjingle.gyp:libjingle_peerconnection',
'../third_party/libjingle/libjingle.gyp:libpeerconnection',
'../third_party/webrtc/system_wrappers/source/system_wrappers.gyp:system_wrappers',
'../third_party/webrtc/modules/modules.gyp:audio_device',
'../third_party/webrtc/video_engine/video_engine.gyp:video_engine_core',
Expand Down
7 changes: 4 additions & 3 deletions content/content_tests.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -196,12 +196,13 @@
'test/webrtc_audio_device_test.h',
],
'dependencies': [
'../third_party/libjingle/libjingle.gyp:libjingle_peerconnection',
'../third_party/libjingle/libjingle.gyp:libpeerconnection',
'../third_party/webrtc/modules/modules.gyp:audio_device',
'../third_party/webrtc/modules/modules.gyp:video_capture_module',
'../third_party/webrtc/system_wrappers/source/system_wrappers.gyp:system_wrappers',
'../third_party/webrtc/video_engine/video_engine.gyp:video_engine_core',
'../third_party/webrtc/voice_engine/voice_engine.gyp:voice_engine_core'],
'../third_party/webrtc/voice_engine/voice_engine.gyp:voice_engine_core'
],
}],
['toolkit_uses_gtk == 1', {
'dependencies': [
Expand Down Expand Up @@ -563,7 +564,7 @@
'renderer/media/webrtc_audio_device_unittest.cc',
],
'dependencies': [
'../third_party/libjingle/libjingle.gyp:libjingle_peerconnection',
'../third_party/libjingle/libjingle.gyp:libpeerconnection',
'../third_party/webrtc/modules/modules.gyp:video_capture_module',
'../third_party/webrtc/system_wrappers/source/system_wrappers.gyp:system_wrappers',
'../third_party/webrtc/video_engine/video_engine.gyp:video_engine_core',
Expand Down
2 changes: 0 additions & 2 deletions jingle/jingle.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,9 @@
'../base/third_party/dynamic_annotations/dynamic_annotations.gyp:dynamic_annotations',
'../net/net.gyp:net',
'../third_party/libjingle/libjingle.gyp:libjingle',
'../third_party/libjingle/libjingle.gyp:libjingle_p2p',
],
'export_dependent_settings': [
'../third_party/libjingle/libjingle.gyp:libjingle',
'../third_party/libjingle/libjingle.gyp:libjingle_p2p',
],
},
# A library for sending and receiving peer-issued notifications.
Expand Down
2 changes: 0 additions & 2 deletions remoting/remoting.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -2289,11 +2289,9 @@
'../jingle/jingle.gyp:jingle_glue',
'../jingle/jingle.gyp:notifier',
'../third_party/libjingle/libjingle.gyp:libjingle',
'../third_party/libjingle/libjingle.gyp:libjingle_p2p',
],
'export_dependent_settings': [
'../third_party/libjingle/libjingle.gyp:libjingle',
'../third_party/libjingle/libjingle.gyp:libjingle_p2p',
],
'sources': [
'jingle_glue/chromium_socket_factory.cc',
Expand Down
Loading

0 comments on commit 5f8d33a

Please sign in to comment.