Skip to content

Commit

Permalink
[Mac] Chromium builds shouldn't ask for access to Chrome's own secure…
Browse files Browse the repository at this point in the history
… data.

The message that this presents is:

Chromium wants to use your confidential information stored in “Chrome Safe
Storage” in your keychain. Do you want to allow access to this item?

Chromium shouldn't ask for access to Google Chrome's data, it should have its
own Chromium Safe Storage item in the keychain.

R=isherman@chromium.org

Review URL: https://codereview.chromium.org/200623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261515 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
mark@chromium.org committed Apr 3, 2014
1 parent 4c43740 commit 51902c1
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions components/os_crypt/keychain_password_mac.mm
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,13 @@
// These two strings ARE indeed user facing. But they are used to access
// the encryption keyword. So as to not lose encrypted data when system
// locale changes we DO NOT LOCALIZE.
#if defined(OFFICIAL_BUILD)
const std::string service_name = "Chrome Safe Storage";
const std::string account_name = "Chrome";
#else
const std::string service_name = "Chromium Safe Storage";
const std::string account_name = "Chromium";
#endif

UInt32 password_length = 0;
void* password_data = NULL;
Expand Down

0 comments on commit 51902c1

Please sign in to comment.