Skip to content

Commit

Permalink
Android: fixes symbol.py lookup paths.
Browse files Browse the repository at this point in the history
These paths can be configured by an environment var,
replace the hardcoded ones.

BUG=

Review URL: https://codereview.chromium.org/55923003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232791 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
bulach@chromium.org committed Nov 4, 2013
1 parent 849447a commit 261d73e
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
1 change: 1 addition & 0 deletions third_party/android_platform/README.chromium
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,4 @@ Android Platform engineering tools, specifically stack symbolization scripts.

Local Modifications:
Only picked the few scripts needed by chrome.
Updated output directories to use environment variable.
9 changes: 5 additions & 4 deletions third_party/android_platform/development/scripts/symbol.py
Original file line number Diff line number Diff line change
Expand Up @@ -106,11 +106,12 @@ def TranslateLibPath(lib):
# If the .so is not found somewhere in CHROME_SYMBOLS_DIR, leave it
# untranslated in case it is an Android symbol in SYMBOLS_DIR.
library_name = os.path.basename(lib)
out_dir = os.environ.get('CHROMIUM_OUT_DIR', 'out')
candidate_dirs = ['.',
'out/Debug/lib',
'out/Debug/lib.target',
'out/Release/lib',
'out/Release/lib.target',
os.path.join(out_dir, 'Debug', 'lib'),
os.path.join(out_dir, 'Debug', 'lib.target'),
os.path.join(out_dir, 'Release', 'lib'),
os.path.join(out_dir, 'Release', 'lib.target'),
]

candidate_libraries = map(
Expand Down

0 comments on commit 261d73e

Please sign in to comment.