Skip to content

Commit

Permalink
Revert of Cleanup: Update the path to vector2d_f.h header. (patchset …
Browse files Browse the repository at this point in the history
…#1 id:1 of https://codereview.chromium.org/781863004/)

Reason for revert:
Breaks Win8 GN and Win8 GN(dbg) builders

Original issue's description:
> Cleanup: Update the path to vector2d_f.h header.
>
> The geometry headers were moved from /ui/gfx/ to ui/gfx/geometry, so
> we are updating the include paths to fix this.
>
> BUG=395370
> TEST=gfx_unittests
> TBR=sky@chromium.org,danakj@chromium.org
>
> Committed: https://crrev.com/b486216287a3e1f30e81f70444f889d321b7819a
> Cr-Commit-Position: refs/heads/master@{#306960}

TBR=danakj@chromium.org,sky@chromium.org,tfarina@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=395370

Review URL: https://codereview.chromium.org/771283003

Cr-Commit-Position: refs/heads/master@{#306962}
  • Loading branch information
lisamuel authored and Commit bot committed Dec 5, 2014
1 parent def3769 commit 0dffffd
Show file tree
Hide file tree
Showing 19 changed files with 42 additions and 36 deletions.
4 changes: 2 additions & 2 deletions android_webview/browser/browser_view_renderer.h
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@
#include "base/debug/trace_event.h"
#include "content/public/browser/android/synchronous_compositor.h"
#include "content/public/browser/android/synchronous_compositor_client.h"
#include "ui/gfx/geometry/rect.h"
#include "ui/gfx/geometry/vector2d_f.h"
#include "ui/gfx/rect.h"
#include "ui/gfx/vector2d_f.h"

class SkCanvas;
class SkPicture;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
#include "base/compiler_specific.h"
#include "content/common/input/input_event_ack_state.h"
#include "content/renderer/input/input_handler_manager_client.h"
#include "ui/gfx/geometry/vector2d_f.h"
#include "ui/gfx/vector2d_f.h"

namespace blink {
class WebInputEvent;
Expand Down
4 changes: 2 additions & 2 deletions content/browser/android/overscroll_glow.h
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
#include "base/memory/ref_counted.h"
#include "base/memory/scoped_ptr.h"
#include "base/time/time.h"
#include "ui/gfx/geometry/size_f.h"
#include "ui/gfx/geometry/vector2d_f.h"
#include "ui/gfx/size_f.h"
#include "ui/gfx/vector2d_f.h"

namespace cc {
class Layer;
Expand Down
4 changes: 2 additions & 2 deletions content/browser/android/overscroll_refresh.h
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
#include "base/memory/scoped_ptr.h"
#include "base/time/time.h"
#include "content/common/content_export.h"
#include "ui/gfx/geometry/size_f.h"
#include "ui/gfx/geometry/vector2d_f.h"
#include "ui/gfx/size_f.h"
#include "ui/gfx/vector2d_f.h"

namespace cc {
class Layer;
Expand Down
4 changes: 2 additions & 2 deletions content/browser/frame_host/render_widget_host_view_guest.h
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@
#include "ui/events/event.h"
#include "ui/events/gestures/gesture_recognizer.h"
#include "ui/events/gestures/gesture_types.h"
#include "ui/gfx/geometry/rect.h"
#include "ui/gfx/geometry/vector2d_f.h"
#include "ui/gfx/native_widget_types.h"
#include "ui/gfx/rect.h"
#include "ui/gfx/vector2d_f.h"

namespace content {
class BrowserPluginGuest;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,10 @@
#include "content/test/test_render_view_host.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "third_party/WebKit/public/web/WebInputEvent.h"
#include "ui/gfx/geometry/point.h"
#include "ui/gfx/geometry/point_f.h"
#include "ui/gfx/geometry/vector2d.h"
#include "ui/gfx/geometry/vector2d_f.h"
#include "ui/gfx/point.h"
#include "ui/gfx/point_f.h"
#include "ui/gfx/vector2d.h"
#include "ui/gfx/vector2d_f.h"

using blink::WebInputEvent;
using blink::WebMouseEvent;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@
#include "content/common/input/synthetic_smooth_scroll_gesture_params.h"
#include "content/common/input/synthetic_web_input_event_builders.h"
#include "third_party/WebKit/public/web/WebInputEvent.h"
#include "ui/gfx/geometry/vector2d.h"
#include "ui/gfx/geometry/vector2d_f.h"
#include "ui/gfx/vector2d.h"
#include "ui/gfx/vector2d_f.h"

namespace content {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@
#include "third_party/WebKit/public/platform/WebGraphicsContext3D.h"
#include "ui/base/android/window_android_observer.h"
#include "ui/events/gesture_detection/filtered_gesture_provider.h"
#include "ui/gfx/geometry/size.h"
#include "ui/gfx/geometry/vector2d_f.h"
#include "ui/gfx/size.h"
#include "ui/gfx/vector2d_f.h"

struct ViewHostMsg_TextInputState_Params;

Expand Down
6 changes: 3 additions & 3 deletions content/common/input_messages.h
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,11 @@
#include "ipc/ipc_message_macros.h"
#include "third_party/WebKit/public/web/WebInputEvent.h"
#include "ui/events/ipc/latency_info_param_traits.h"
#include "ui/gfx/geometry/point.h"
#include "ui/gfx/geometry/rect.h"
#include "ui/gfx/geometry/vector2d_f.h"
#include "ui/gfx/ipc/gfx_param_traits.h"
#include "ui/gfx/point.h"
#include "ui/gfx/range/range.h"
#include "ui/gfx/rect.h"
#include "ui/gfx/vector2d_f.h"

#undef IPC_MESSAGE_EXPORT
#define IPC_MESSAGE_EXPORT CONTENT_EXPORT
Expand Down
10 changes: 5 additions & 5 deletions content/common/view_messages.h
Original file line number Diff line number Diff line change
Expand Up @@ -49,13 +49,13 @@
#include "ui/base/ime/text_input_mode.h"
#include "ui/base/ime/text_input_type.h"
#include "ui/base/ui_base_types.h"
#include "ui/gfx/geometry/point.h"
#include "ui/gfx/geometry/rect.h"
#include "ui/gfx/geometry/rect_f.h"
#include "ui/gfx/geometry/vector2d.h"
#include "ui/gfx/geometry/vector2d_f.h"
#include "ui/gfx/ipc/gfx_param_traits.h"
#include "ui/gfx/point.h"
#include "ui/gfx/range/range.h"
#include "ui/gfx/rect.h"
#include "ui/gfx/rect_f.h"
#include "ui/gfx/vector2d.h"
#include "ui/gfx/vector2d_f.h"

#if defined(OS_MACOSX)
#include "content/common/mac/font_descriptor.h"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

#include "base/basictypes.h"
#include "ui/gfx/geometry/size_f.h"
#include "ui/gfx/geometry/vector2d_f.h"
#include "ui/gfx/vector2d_f.h"

namespace content {

Expand Down
2 changes: 1 addition & 1 deletion content/renderer/input/input_event_filter.cc
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
#include "content/public/common/content_switches.h"
#include "ipc/ipc_listener.h"
#include "ipc/ipc_sender.h"
#include "ui/gfx/geometry/vector2d_f.h"
#include "ui/gfx/vector2d_f.h"

using blink::WebInputEvent;

Expand Down
2 changes: 1 addition & 1 deletion content/renderer/input/input_handler_manager_client.h
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
#include "base/callback.h"
#include "base/callback_forward.h"
#include "content/common/content_export.h"
#include "ui/gfx/geometry/vector2d_f.h"
#include "ui/gfx/vector2d_f.h"

namespace ui {
struct LatencyInfo;
Expand Down
6 changes: 3 additions & 3 deletions content/renderer/render_widget.h
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,11 @@
#include "ui/base/ime/text_input_mode.h"
#include "ui/base/ime/text_input_type.h"
#include "ui/base/ui_base_types.h"
#include "ui/gfx/geometry/rect.h"
#include "ui/gfx/geometry/vector2d.h"
#include "ui/gfx/geometry/vector2d_f.h"
#include "ui/gfx/native_widget_types.h"
#include "ui/gfx/range/range.h"
#include "ui/gfx/rect.h"
#include "ui/gfx/vector2d.h"
#include "ui/gfx/vector2d_f.h"
#include "ui/surface/transport_dib.h"

struct ViewHostMsg_UpdateRect_Params;
Expand Down
2 changes: 1 addition & 1 deletion content/test/test_render_view_host.h
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
#include "ui/base/ime/dummy_text_input_client.h"
#include "ui/base/layout.h"
#include "ui/base/page_transition_types.h"
#include "ui/gfx/geometry/vector2d_f.h"
#include "ui/gfx/vector2d_f.h"

// This file provides a testing framework for mocking out the RenderProcessHost
// layer. It allows you to test RenderViewHost, WebContentsImpl,
Expand Down
3 changes: 1 addition & 2 deletions ui/base/android/window_android.h
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,12 @@

#include <jni.h>
#include <vector>

#include "base/android/jni_weak_ref.h"
#include "base/android/scoped_java_ref.h"
#include "base/observer_list.h"
#include "base/time/time.h"
#include "ui/base/ui_base_export.h"
#include "ui/gfx/geometry/vector2d_f.h"
#include "ui/gfx/vector2d_f.h"

namespace ui {

Expand Down
2 changes: 1 addition & 1 deletion ui/gfx/transform.h
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@

#include "base/compiler_specific.h"
#include "third_party/skia/include/utils/SkMatrix44.h"
#include "ui/gfx/geometry/vector2d_f.h"
#include "ui/gfx/gfx_export.h"
#include "ui/gfx/vector2d_f.h"

namespace gfx {

Expand Down
7 changes: 7 additions & 0 deletions ui/gfx/vector2d_f.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
// Copyright 2013 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

// TODO(beng): remove once callsites are patched.
#include "ui/gfx/geometry/vector2d_f.h"

2 changes: 1 addition & 1 deletion ui/views/widget/desktop_aura/x11_whole_screen_move_loop.h
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@
#include "base/memory/weak_ptr.h"
#include "ui/base/cursor/cursor.h"
#include "ui/events/platform/platform_event_dispatcher.h"
#include "ui/gfx/geometry/vector2d_f.h"
#include "ui/gfx/image/image_skia.h"
#include "ui/gfx/native_widget_types.h"
#include "ui/gfx/vector2d_f.h"
#include "ui/gfx/x/x11_types.h"
#include "ui/views/widget/desktop_aura/x11_move_loop.h"
#include "ui/views/widget/desktop_aura/x11_move_loop_delegate.h"
Expand Down

0 comments on commit 0dffffd

Please sign in to comment.