Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add some delay before servers are sync" #1974

Conversation

arnauds5
Copy link
Collaborator

Reverts #1970

delay on backend is not reliable enough, it should maybe be done on frontends instead

@arnauds5 arnauds5 requested a review from a team as a code owner June 30, 2024 16:39
Copy link

Pull reviewers stats

Stats of the last 30 days for popstellar:

User Total reviews Time to review Total comments
K1li4nL
🥇
27
▀▀▀▀
12h 13m
12
▀▀
matteosz
🥈
12
▀▀
2d 6m
22
▀▀▀
arnauds5
🥉
8
1h 57m
4
emonnin-epfl
8
8h 20m
8
sgueissa
5
1h 25m
7
MariemBaccari
4
2h 2m
6
onsriahi14
3
1d 10h 51m
4
quadcopterman
3
10d 7h 3m
▀▀
1
4xiom5
2
21d 11h 22m
▀▀▀▀
0
1florentin
2
10d 5h 50m
▀▀
0
Kaz-ookid
2
2d 4h 12m
9
simone-kalbermatter
1
9h 17m
0
⚡️ Pull request stats

Copy link

sonarcloud bot commented Jun 30, 2024

Copy link

sonarcloud bot commented Jun 30, 2024

Copy link

sonarcloud bot commented Jun 30, 2024

Copy link

sonarcloud bot commented Jun 30, 2024

Copy link
Collaborator

@sgueissa sgueissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sgueissa sgueissa enabled auto-merge June 30, 2024 17:43
Copy link
Contributor

@K1li4nL K1li4nL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blind approval

@sgueissa sgueissa added this pull request to the merge queue Jun 30, 2024
Merged via the queue into master with commit 144e13c Jun 30, 2024
18 checks passed
@sgueissa sgueissa deleted the revert-1970-work-be1-arnauds5-delay-federationresult-after-sync branch June 30, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants