Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send rumors state when connecting federaction #1958

Merged
merged 3 commits into from
Jun 27, 2024
Merged

Send rumors state when connecting federaction #1958

merged 3 commits into from
Jun 27, 2024

Conversation

arnauds5
Copy link
Collaborator

  • Send rumors state when connecting federaction
  • Send rumors state when receiving a connection from federation
  • Send greet server when connecting federaction

@arnauds5 arnauds5 requested a review from a team as a code owner June 27, 2024 19:26
@github-actions GitHub Actions
Copy link

Pull reviewers stats

Stats of the last 30 days for popstellar:

User Total reviews Time to review Total comments
K1li4nL
🥇		 24
▀▀▀▀		 1d 19h 44m
 12
▀▀
arnauds5
🥈		 7
▀		 4h 29m
 4
▀
matteosz
🥉		 7
▀		 3d 16h 27m
▀		 21
▀▀▀
emonnin-epfl
 6
▀		 8h 20m
 8
▀
sgueissa
 3
▀		 7h 59m
 5
▀
quadcopterman
 3
▀		 10d 7h 3m
▀▀▀		 1
1florentin
 2
 10d 5h 50m
▀▀▀		 0
MariemBaccari
 2
 22h 39m
 6
▀
simone-kalbermatter
 2
 5h 32m
 0
onsriahi14
 2
 6d 4h 27m
▀▀		 4
▀
Kaz-ookid
 1
 3d 19h 13m
▀		 5
▀
⚡️ Pull request stats

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 27, 2024

Quality Gate Passed Quality Gate passed for 'PoP - PoPCHA-Web-Client'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 27, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Be1-Go'

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
88.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 27, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Be2-Scala'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 27, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Fe2-Android'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@arnauds5 arnauds5 requested a review from sgueissa June 27, 2024 19:40
@sgueissa sgueissa enabled auto-merge June 27, 2024 20:51
@sgueissa
Copy link
Collaborator

LGTM

K1li4nL
K1li4nL approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@K1li4nL K1li4nL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blind approval

@sgueissa sgueissa added this pull request to the merge queue Jun 27, 2024
Merged via the queue into master with commit 444a91c Jun 27, 2024
18 checks passed
@sgueissa sgueissa deleted the work-be1-arnauds5-federation-sync2 branch June 27, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@K1li4nL K1li4nL K1li4nL approved these changes

@sgueissa sgueissa sgueissa approved these changes

Assignees
No one assigned
Labels
be1-go
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arnauds5 @sgueissa @K1li4nL