Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BE1][BE2] Add timestamp to rumors #1931

Merged
merged 6 commits into from
Jun 14, 2024
Merged

[BE1][BE2] Add timestamp to rumors #1931

merged 6 commits into from
Jun 14, 2024

Conversation

DanielTavaresA
Copy link
Collaborator

To be able to add partial ordering to messages, we want to add a vector clock to each rumor. For this, jsonRPC of Rumor has been changed with the addition of a RumorState object, that will represent the rumor state in which a rumor has been sent

@DanielTavaresA DanielTavaresA requested a review from a team as a code owner June 14, 2024 13:18
@github-actions GitHub Actions
Copy link

Pull reviewers stats

Stats of the last 30 days for popstellar:

User Total reviews Time to review Total comments
K1li4nL
🥇		 18
▀▀▀▀		 2d 10h 24m
▀		 10
▀▀▀
arnauds5
🥈		 5
▀		 1d 5h 11m
 3
▀
emonnin-epfl
🥉		 5
▀		 8h 20m
 9
▀▀▀
simone-kalbermatter
 3
▀		 1h 47m
 0
onsriahi14
 3
▀		 23h 11m
 1
matteosz
 3
▀		 14h 5m
 3
▀
pierluca
 2
 3d 11h 3m
▀		 1
MariemBaccari
 2
 22h 39m
 6
▀▀
DanielTavaresA
 2
 9d 21h 46m
▀▀▀▀		 2
▀
sgueissa
 1
 6d 11h 44m
▀▀		 1
⚡️ Pull request stats

@github-actions github-actions bot mentioned this pull request Jun 14, 2024
Closed
@github-actions GitHub Actions
Copy link

🟠 There seems to be some formatting issues that must be applied from PR #1932 first.

@sgueissa sgueissa self-assigned this Jun 14, 2024
@sgueissa sgueissa changed the title Add clock to rumors [BE1][BE2] Add timestamp to rumors Jun 14, 2024
sgueissa
sgueissa reviewed Jun 14, 2024
View reviewed changes
docs/protocol.md
@@ -982,6 +985,12 @@ RPC
"params": {
"sender_id": "J9fBzJV70Jk5c-i3277Uq4CmeL4t53WDfUghaK0HpeM=",
"rumor_id": 1,
"timestamp" : {
"J9fBzJV70Jk5c-i3277Uq4CmeL4t53WDfUghaK0HpeM=": 3,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you change "J9fBzJV70Jk5c-i3277Uq4CmeL4t53WDfUghaK0HpeM=": 3, to "J9fBzJV70Jk5c-i3277Uq4CmeL4t53WDfUghaK0HpeM=": 1, same for the other place

docs/protocol.md
@@ -1127,6 +1141,12 @@ Response in case of success
{
"sender_id": "J9fBzJV70Jk5c-i3277Uq4CmeL4t53WDfUghaK0HpeM=",
"rumor_id": 1,
"timestamp" : {
"J9fBzJV70Jk5c-i3277Uq4CmeL4t53WDfUghaK0HpeM=": 3,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

docs/protocol.md
@@ -1142,6 +1162,12 @@ Response in case of success
{
"sender_id": "J9fBzJV70Jk5c-i3277Uq4CmeL4t53WDfUghaK0HpeM=",
"rumor_id": 2,
"timestamp" : {
"J9fBzJV70Jk5c-i3277Uq4CmeL4t53WDfUghaK0HpeM=": 3,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same but change to 2

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 14, 2024

Quality Gate Passed Quality Gate passed for 'PoP - PoPCHA-Web-Client'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 14, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Be2-Scala'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

sgueissa
sgueissa approved these changes Jun 14, 2024
View reviewed changes
Copy link
Collaborator

@sgueissa sgueissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 14, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Fe2-Android'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 14, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Be1-Go'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sgueissa sgueissa enabled auto-merge June 14, 2024 14:30
@sgueissa sgueissa added this pull request to the merge queue Jun 14, 2024
Merged via the queue into master with commit 942eea7 Jun 14, 2024
17 checks passed
@sgueissa sgueissa deleted the work-protocol-add-clock branch June 14, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@K1li4nL K1li4nL K1li4nL approved these changes

@sgueissa sgueissa sgueissa approved these changes

Assignees

@sgueissa sgueissa

@DanielTavaresA DanielTavaresA

Labels
be1-go be2-scala
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DanielTavaresA @sgueissa @K1li4nL