You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement the witness-message and meetings handling
Refactor PopCha
Better documentation
Add a better logging system
Add some integration tests
Add karate tests
PS1: A lot of files and lines modified because I moved a lot of code, changed a lot of directories and packages name
PS2: don't mind anything inside the old directory
The reason will be displayed to describe this comment to others. Learn more.
There are a few imports that are renamed such as mlao2, mocks2, mreaction2, mfederation2, generator2, melection2, mconsensus2, mchirp2.
And multiple different methods (munsuscribe, mrumor, mheartbeat, etc) are imported as method2.
Is there a particular reason for this ?
Otherwise. the PR looks good to me.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sgueissa
changed the title
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
In this PR, we merged the logic, message structures and types in one place and add some quick documentation.
In this PR the following are still missing but will be done in the next PRs:
PS1: A lot of files and lines modified because I moved a lot of code, changed a lot of directories and packages name
PS2: don't mind anything inside the old directory