Sending Sorted Attendees List and Validation for CloseRollCall #1906
Conversation
…erifying list is sorted when displaying (organizer or attendee) + keeping order of attendees list as received
Pull reviewers statsStats of the last 30 days for popstellar:
|
…r de-anonymization toast + other things
...roid/app/src/main/java/com/github/dedis/popstellar/ui/lao/event/rollcall/RollCallFragment.kt
Outdated
Show resolved
Hide resolved
...ndroid/app/src/main/java/com/github/dedis/popstellar/utility/handler/data/RollCallHandler.kt
Outdated
Show resolved
Hide resolved
| rollCallRepo.updateRollCall(LAO_ID, ROLL_CALL_UNSORTED_ATTENDEES) | ||
| rollCallRepo.updateRollCall(LAO_ID, closeRollCall(ROLL_CALL_UNSORTED_ATTENDEES)) | ||
| InstrumentationRegistry.getInstrumentation().waitForIdleSync() | ||
| openRollCallWithDescription(ROLL_CALL_UNSORTED_ATTENDEES) |
There was a problem hiding this comment.
I think that this call here may actually be useless, it should be sufficient to update the repository (as long as you modify the roll call that is currently set in the fragment)
There was a problem hiding this comment.
I am not sure, tests do not pass the rollCallListAttendees visibility part if I don't put this line
…-list' into work-fe2-maxime-sorted-attendees-list # Conflicts: # fe2-android/app/src/main/java/com/github/dedis/popstellar/ui/lao/event/rollcall/RollCallArrayAdapter.kt # fe2-android/app/src/main/java/com/github/dedis/popstellar/ui/lao/event/rollcall/RollCallFragment.kt
|
|
|
|
|
Summary
Addressing issue #1847. FE2 Organizers were sending unordered list of scanned attendees for a
RollCall, enhancing risks of de-anonymization.Main Changes
HashSettoLinkedHashSet(inRollCallscope) to keep the set ordered as it came inOther Changes
I added checking for ordered attendees list at creation, so I also added full validation of message data while I was here.
UI Updates