Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BE1] Better error handling #1902

Merged
merged 69 commits into from
Jun 3, 2024

Conversation

sgueissa
Copy link
Collaborator

@sgueissa sgueissa commented Jun 3, 2024

This PR has for purpose to rework all the errors to prepare the code for having better logs.

We removed the bad return type *answer.Error from everywhere and replace it with error, for that we created an error type with a stacktrace for this project named PopError.

Copy link

github-actions bot commented Jun 3, 2024

Pull reviewers stats

Stats of the last 30 days for popstellar:

User Total reviews Time to review Total comments
K1li4nL
🥇
12
▀▀▀
4d 19h 42m
14
▀▀▀
simone-kalbermatter
🥈
4
8h 40m
0
onsriahi14
🥉
4
1d 23h 8m
4
matteosz
3
4d 40m
5
pierluca
2
3d 11h 3m
1
arnauds5
2
5d 15h 3m
▀▀
0
emonnin-epfl
2
3h 14m
2
DanielTavaresA
2
2d 10h 22m
8
▀▀
quadcopterman
2
6d 13h 46m
▀▀
1
Tyratox
1
44m
0
sgueissa
1
6d 11h 44m
▀▀
1
osm-alt
1
25m
0
Kaz-ookid
1
1d 2h 1m
5
⚡️ Pull request stats

Copy link

sonarcloud bot commented Jun 3, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Fe1-Web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sgueissa sgueissa marked this pull request as ready for review June 3, 2024 18:56
@sgueissa sgueissa requested a review from a team as a code owner June 3, 2024 18:56
Copy link

sonarcloud bot commented Jun 3, 2024

Quality Gate Passed Quality Gate passed for 'PoP - PoPCHA-Web-Client'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Jun 3, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Be2-Scala'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Jun 3, 2024

Quality Gate Failed Quality Gate failed for 'PoP - Be1-Go'

Failed conditions
0.0% Coverage on New Code (required ≥ 65%)

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Jun 3, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Fe2-Android'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

@K1li4nL K1li4nL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blind approval

@K1li4nL K1li4nL added this pull request to the merge queue Jun 3, 2024
Merged via the queue into master with commit f5ff150 Jun 3, 2024
16 of 17 checks passed
@K1li4nL K1li4nL deleted the work-be1-stuart-etienne-better-error-handling branch June 3, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants