[BE2] Added RumorState handler #1890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-daniel-pull-rumor-handler
Pull reviewers statsStats of the last 30 days for popstellar:
|
DanielTavaresA
changed the base branch from
master
to
work-be2-daniel-response-pull-state-json
Base automatically changed from
work-be2-daniel-response-pull-state-json
to
master
May 29, 2024 08:49
onsriahi14
previously approved these changes
May 29, 2024
K1li4nL
requested changes
May 30, 2024
Comment on lines
9
to
18
| import ch.epfl.pop.model.network.method.message.Message | ||
| import ch.epfl.pop.model.network.method.{GreetServer, Rumor} | ||
| import ch.epfl.pop.model.network.method.{GreetServer, Rumor, RumorState} | ||
| import ch.epfl.pop.model.network.{JsonRpcRequest, JsonRpcResponse, MethodType} | ||
| import ch.epfl.pop.model.objects.{Base64Data, Channel, PublicKey, RumorData} | ||
| import ch.epfl.pop.pubsub.AskPatternConstants | ||
| import ch.epfl.pop.pubsub.ClientActor.ClientAnswer | ||
| import ch.epfl.pop.pubsub.graph.validators.RpcValidator | ||
| import ch.epfl.pop.pubsub.graph.{ErrorCodes, GraphMessage, PipelineError} | ||
| import ch.epfl.pop.storage.DbActor | ||
| import ch.epfl.pop.storage.DbActor.{DbActorAck, DbActorReadRumor, DbActorReadRumorData} | ||
| import ch.epfl.pop.storage.DbActor.{DbActorAck, DbActorGenerateRumorStateAns, DbActorReadRumor, DbActorReadRumorData} |
There was a problem hiding this comment.
Not sure these imports are necessary ?
There was a problem hiding this comment.
Probably there from an old version, will remove
Comment on lines
-46
to
-60
|
|
||
| test("constructor from json works for RumorState") { | ||
| val state: Map[PublicKey, Int] = Map( | ||
| PublicKey(Base64Data.encode("1")) -> 1, | ||
| PublicKey(Base64Data.encode("2")) -> 2, | ||
| PublicKey(Base64Data.encode("3")) -> 3 | ||
| ) | ||
|
|
||
| val rumorState: RumorState = RumorState(state) | ||
|
|
||
| val encodedDecoded = RumorState.buildFromJson(rumorState.toJsonString) | ||
|
|
||
| encodedDecoded.state shouldBe state | ||
| } | ||
|
|
There was a problem hiding this comment.
Moved to RumorStateSuite apparently
|
|
|
|
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pending on #1889
When receiving a RumorState query, we send back a response with the list of rumors that are missing from the sender